Commit df4acbd
fix: use locale-neutral Windows ACL for build data (#3887)
On localized Windows installations, `build_data_writer.ps1` could fail
when
creating the output file ACL because it used the English localized
`Everyone`
principal name.
This changes the ACL rule to use the language-neutral `WorldSid`
identity
instead, preserving the existing Everyone read permission without
depending on
the display language of Windows.
Before: German and other localized Windows installs could fail with
`IdentityMappedException` / `IdentityNotMappedException`.
After: build data generation succeeds on localized Windows installs.
Fixes #3886
Tests:
`bazelisk test //tests/build_data:build_data_test --config=fast-tests`
---------
Co-authored-by: Richard Levasseur <richardlev@gmail.com>
(cherry picked from commit 8629003)
Work towards #38671 parent 721ca37 commit df4acbd
2 files changed
Lines changed: 12 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
| 57 | + | |
57 | 58 | | |
58 | 59 | | |
59 | 60 | | |
| |||
76 | 77 | | |
77 | 78 | | |
78 | 79 | | |
| 80 | + | |
79 | 81 | | |
80 | 82 | | |
81 | 83 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
25 | 34 | | |
26 | 35 | | |
27 | 36 | | |
| |||
0 commit comments