Release 2.0.5 #526
Merged
Release 2.0.5 #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add log_gamma diagnostic * add missing export for log_gamma * add missing export for gamma_null_distribution, gamma_discrepancy * fix broken unit tests * rename log_gamma module to sbc * add test_log_gamma unit test * add return information to log_gamma doc string * fix typo in docstring, use fixed-length np array to collect log_gammas instead of appending to an empty list
…525) * standardization: add test for multi-input values (failing) This test reveals to bugs in the standarization layer: - count is updated multiple times - batch_count is too small, as the sizes from reduce_axes have to be multiplied * breaking: fix bugs regarding count in standardization layer Fixes #524 This fixes the two bugs described in c4cc133: - count was accidentally updated, leading to wrong values - count was calculated wrongly, as only the batch size was used. Correct is the product of all reduce dimensions. This lead to wrong standard deviations While the batch dimension is the same for all inputs, the size of the second dimension might vary. For this reason, we need to introduce an input-specific `count` variable. This breaks serialization. * fix assert statement in test
Codecov ReportAttention: Patch coverage is
|
|
@paul-buerkner Done. @LarsKue Thanks for the review! I think we can merge when all tests have passed. |
|
The failing test (model comparison notebook) worked with 7c094c5 and nothing related seems to have changed, so it seems to be flaky for some reason. I also cannot reproduce the error locally, can any of you? The command would be: I have restarted the two remaining tests, we'll see if they pass now... @LarsKue Do you think it might make sense to split up the slow tests a bit more (e.g., in tests and examples), so we get shorter total runtime by running them in parallel? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This bugfix release v2.0.5 contains fixes and minor improvements. Deprecations planned for v2.0.5 are postponed to v2.0.6.
Important
This release contains breaking changes. You will not be able to load models trained with v2.0.4 or earlier.
Breaking Changes
Standardizationlayer, used in the approximators.Minor Changes
MultivariateNormalScoreBug Fixes