Proxies #1147
Merged
Proxies #1147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisrink10
force-pushed
the
feature/proxies
branch
3 times, most recently
from
d956991 to
97e6069
Compare
chrisrink10
force-pushed
the
feature/proxies
branch
from
97e6069 to
1fdabfd
Compare
chrisrink10
force-pushed
the
feature/proxies
branch
from
1fdabfd to
ff7b92b
Compare
chrisrink10
force-pushed
the
feature/proxies
branch
from
ff7b92b to
018e935
Compare
chrisrink10
force-pushed
the
feature/proxies
branch
from
018e935 to
6152cd9
Compare
chrisrink10
commented
Apr 20, 2025
| @@ -6285,7 +6286,7 @@ | |||
| (let [name-str (name interface-name) | |||
| method-sigs (->> methods | |||
| (map (fn [[method-name args docstring]] | |||
| [method-name (conj args 'self) docstring])) | |||
| [method-name (vec (concat ['self] args)) docstring])) | |||
There was a problem hiding this comment.
This was always shoving self at the end of the argument vector.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #425
Fixes #1241