feat(playcanvas): cached quat factory

basics · Sep 26, 2019 · 7beb643 · 7beb643
1 parent 34dc1e9
commit 7beb643
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/src/adapter/playcanvas.js b/src/adapter/playcanvas.js
@@ -1,6 +1,6 @@
 // @ts-nocheck
 import {
-  operatorCalc, cachedValueOf, defineVectorLength, cachedFactory
+  operatorCalc, cachedValueOf, defineVectorLength, cachedFactory, cachedFunction
 } from '../operator';
 
 function fallbackWindow() {
@@ -59,9 +59,15 @@ export function hijackPlayCanvas(pc) {
       throw new Error('set up not allowed');
     }
   });
-  Quat.fromDir = function (dir, up = Vec3.UP) {
-    return new Quat().setFromMat4(new Mat4().setLookAt(Vec3.ZERO, dir, up));
-  };
+  pc.quat = cachedFunction((x, y, z, w) => {
+    if (typeof dir === 'number') {
+      return new Quat(x, y, z, w);
+    }
+    if (!x) {
+      return new Quat();
+    }
+    return new Quat().setFromMat4(new Mat4().setLookAt(Vec3.ZERO, x, y || Vec3.UP));
+  });
 }
 
 // eslint-disable-next-line no-undef

diff --git a/src/operator.js b/src/operator.js
@@ -202,3 +202,7 @@ export function defineVectorLength(VectorClass, value) {
 export function cachedFactory(VectorClass) {
   return bindCache((...args) => new VectorClass(...args));
 }
+
+export function cachedFunction(realFactory) {
+  return bindCache((...args) => realFactory(...args));
+}