Skip to content

Commit b11caa3

Browse files
fippoWebRTC LUCI CQ
authored andcommitted
Remove obsolete IceProtocolType enum and SetIceProtocolType
which only had a single member after the removal of GICE around M42. The last downstream usage in Chromoting was removed in https://chromium-review.googlesource.com/c/chromium/src/+/4385113 BUG=webrtc:4299 Change-Id: Id444967822cd19b0e514ba70739a8d45a7f78fae Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/299600 Reviewed-by: Jonas Oreland <jonaso@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#39945}
1 parent 83c8a3b commit b11caa3

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

p2p/base/ice_transport_internal.h

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -228,12 +228,6 @@ enum class IceTransportState {
228228
STATE_FAILED
229229
};
230230

231-
// TODO(zhihuang): Remove this once it's no longer used in
232-
// remoting/protocol/libjingle_transport_factory.cc
233-
enum IceProtocolType {
234-
ICEPROTO_RFC5245 // Standard RFC 5245 version of ICE.
235-
};
236-
237231
// IceTransportInternal is an internal abstract class that does ICE.
238232
// Once the public interface is supported,
239233
// (https://www.w3.org/TR/webrtc/#rtcicetransport)
@@ -256,10 +250,6 @@ class RTC_EXPORT IceTransportInternal : public rtc::PacketTransportInternal {
256250

257251
virtual void SetIceTiebreaker(uint64_t tiebreaker) = 0;
258252

259-
// TODO(zhihuang): Remove this once it's no longer called in
260-
// remoting/protocol/libjingle_transport_factory.cc
261-
virtual void SetIceProtocolType(IceProtocolType type) {}
262-
263253
virtual void SetIceCredentials(absl::string_view ice_ufrag,
264254
absl::string_view ice_pwd);
265255

0 commit comments

Comments
 (0)