Skip to content

Commit 8b5bf6d

Browse files
perkjWebRTC LUCI CQ
authored andcommitted
[WebRTC-SendPacketsOnWorkerThread] Delete MaybeWorkerThread
This helper class is no longer used. Bug: webrtc:14502 Change-Id: I7940de762ebb9a7c6d04927603f249f5b0061051 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301161 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39880}
1 parent 1f251dd commit 8b5bf6d

File tree

6 files changed

+3
-398
lines changed

6 files changed

+3
-398
lines changed

modules/BUILD.gn

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,6 @@ if (rtc_include_tests && !build_with_chromium) {
227227
"pacing:pacing_unittests",
228228
"remote_bitrate_estimator:remote_bitrate_estimator_unittests",
229229
"rtp_rtcp:rtp_rtcp_unittests",
230-
"utility:utility_unittests",
231230
"video_coding:video_coding_unittests",
232231
"video_coding/deprecated:deprecated_unittests",
233232
"video_coding/timing:timing_unittests",

modules/pacing/task_queue_paced_sender.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,13 @@
2020
#include "absl/types/optional.h"
2121
#include "api/field_trials_view.h"
2222
#include "api/sequence_checker.h"
23-
#include "api/task_queue/task_queue_factory.h"
23+
#include "api/task_queue/pending_task_safety_flag.h"
2424
#include "api/units/data_size.h"
2525
#include "api/units/time_delta.h"
2626
#include "api/units/timestamp.h"
2727
#include "modules/pacing/pacing_controller.h"
2828
#include "modules/pacing/rtp_packet_pacer.h"
2929
#include "modules/rtp_rtcp/source/rtp_packet_to_send.h"
30-
#include "modules/utility/maybe_worker_thread.h"
3130
#include "rtc_base/experiments/field_trial_parser.h"
3231
#include "rtc_base/numerics/exp_filter.h"
3332
#include "rtc_base/thread_annotations.h"

modules/utility/BUILD.gn

Lines changed: 2 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -9,38 +9,16 @@
99
import("../../webrtc.gni")
1010

1111
rtc_source_set("utility") {
12-
sources = [
13-
"maybe_worker_thread.cc",
14-
"maybe_worker_thread.h",
15-
]
16-
17-
deps = [
18-
"../../api:field_trials_view",
19-
"../../api:sequence_checker",
20-
"../../api/task_queue",
21-
"../../api/task_queue:pending_task_safety_flag",
22-
"../../rtc_base:checks",
23-
"../../rtc_base:logging",
24-
"../../rtc_base:macromagic",
25-
"../../rtc_base:rtc_event",
26-
"../../rtc_base:rtc_task_queue",
27-
]
28-
29-
absl_deps = [
30-
"//third_party/abseil-cpp/absl/functional:any_invocable",
31-
"//third_party/abseil-cpp/absl/strings:strings",
32-
]
33-
3412
if (is_android) {
3513
visibility = [ "*" ]
36-
sources += [
14+
sources = [
3715
"include/helpers_android.h",
3816
"include/jvm_android.h",
3917
"source/helpers_android.cc",
4018
"source/jvm_android.cc",
4119
]
4220

43-
deps += [
21+
deps = [
4422
"../../api:sequence_checker",
4523
"../../rtc_base:checks",
4624
"../../rtc_base:logging",
@@ -49,26 +27,3 @@ rtc_source_set("utility") {
4927
]
5028
}
5129
}
52-
53-
if (rtc_include_tests) {
54-
rtc_library("utility_unittests") {
55-
testonly = true
56-
57-
sources = [ "maybe_worker_thread_unittests.cc" ]
58-
deps = [
59-
":utility",
60-
"../../api:sequence_checker",
61-
"../../api/task_queue",
62-
"../../api/task_queue:default_task_queue_factory",
63-
"../../api/task_queue:pending_task_safety_flag",
64-
"../../api/units:time_delta",
65-
"../../rtc_base:rtc_event",
66-
"../../rtc_base:threading",
67-
"../../test:explicit_key_value_config",
68-
"../../test:field_trial",
69-
"../../test:test_main",
70-
"../../test:test_support",
71-
"../../test/time_controller",
72-
]
73-
}
74-
}

modules/utility/maybe_worker_thread.cc

Lines changed: 0 additions & 99 deletions
This file was deleted.

modules/utility/maybe_worker_thread.h

Lines changed: 0 additions & 86 deletions
This file was deleted.

0 commit comments

Comments
 (0)