Fix invalid clock glyph in time notification#5957
Open
stefanomainardi wants to merge 1 commit into
Open
Conversation
The "Show time" notification used U+F43A — in the Nerd Font legacy MDI codepoint range (3-byte UTF-8). With mako's default `font=sans-serif` this PUA character does not always fall through to a Nerd Font, so the icon renders as a "tofu" / blank box (reported in basecamp#5776). Every other glyph in omarchy (monitor, clipboard, idle, silenced notifications, recharge, etc.) is in the modern MDI range (4-byte UTF-8, U+F0000–U+F1AB9). Replace the legacy clock with `nf-md-clock-outline` (U+F0150, ) so it follows the same convention as the rest. Closes basecamp#5776.
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the "invalid icon" rendered for the Show time notification (
SUPER + CTRL + ALT + T) reported in #5776.Root cause
bin/omarchy-notification-timepassed-g <U+F43A>toomarchy-notification-send. That codepoint is in the Nerd Font legacy MDI range (3-byte UTF-8,EF 90 BA). The mako defaultfont=sans-serif 14pxdoes not reliably fall through to a Nerd Font for PUA characters in that range, so the glyph renders as a blank box / tofu.Every other glyph used by omarchy notifications lives in the modern MDI range (4-byte UTF-8,
U+F0000–U+F1AB9). Examples already in tree:nf-md-monitoromarchy-hyprland-monitor-internalnf-md-monitor_dashboardomarchy-hyprland-workspace-layout-togglenf-md-content_pasteomarchy-capture-text-extractionnf-md-sleep_offomarchy-toggle-idlenf-md-bell_off_outlineomarchy-toggle-notification-silencingnf-md-flashomarchy-battery-monitorThe time notification was the only outlier on the legacy range — making it the only one that fails to render on a stock mako setup.
Change
isnf-md-clock-outline(U+F0150) — same MDI family used elsewhere.Note for
masterbackportThe same buggy glyph exists on
masterindefault/hypr/bindings/utilities.conf:55(inlinenotify-sendcall). If you'd like the fix backported there too, happy to open a follow-up PR — just say the word.Test plan
bash -n bin/omarchy-notification-time— syntax cleanomarchy-notification-send -g <glyph>accepts the new value (script signature unchanged)JetBrainsMono Nerd Font(omarchy default) ships U+F0150 (fc-match -s :charset=F0150)