Prototype attachment gallery support #396
Open
+530
−149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create AttachmentGalleryNode to wrap 2+ uploaded images - Update gallery grid layout (2-col, 3-col) based on image count - Move cursor outside gallery after upload/deletion to prevent layout issues - Auto-unwrap gallery when reduced to 1 or 0 images - Add CSS grid styling for attachment galleries - Add tests for gallery creation and deletion behavior
Author
|
@jorgemanrubia would appreciate your initial thoughts on this. I had another PR but it diverged too much from main, so this is a fresh one. It also adds support for deleting images from galleries. |
- Ensure empty paragraph exists after gallery when replacing last node - Simplify cursor positioning to only look forward (next sibling) - Create new paragraph after gallery if next node isn't suitable - Fixes cursor appearing in gallery grid cells after drag-and-drop
Member
|
Hey @lylo thank you so much for your work exploring galleries. I will review this one soon, sorry I have been busy with several fronts (new product on its final stage! 😅). |
Author
|
Not a problem! Thanks for taking the time to have a look, really appreciate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof of concept for basic attachment gallery support. I'm hoping it starts a discussion about whether this is the right direction to take with galleries.
It adds a new AttachmentGalleryNode object which wraps multiple
<action-text-attachment>nodes in a<div>. You can also delete nodes in a gallery and have it correctly reformat based on the remaining nodes.It supports up to 9 images in a 3x3 grid (like Trix). Inserting via the toolbar and drag and drop is supported.
Known limitations