Add --subscribe / --no-subscribe to recording creation commands (#187)

* Bump SDK to v0.2.2

Picks up Subscriptions field on create request types
(CreateMessageRequest, CreateDocumentRequest, CreateScheduleEntryRequest).

* Add --subscribe / --no-subscribe to recording creation commands

Controls who gets subscribed and notified when creating messages, docs,
and schedule entries. Critical for bot/agent use cases that need silent
creation.

  --no-subscribe        subscribe nobody (no notifications)
  --subscribe "X,Y"     subscribe specific people (names, emails, IDs, "me")

Mutually exclusive. Neither flag preserves server default (everyone).
Explicit --subscribe with no resolvable people is a hard error, including
--subscribe "" (via cmd.Flags().Changed detection).

Available on: message, messages create, docs create, schedule create.

Closes #182

* Address PR review feedback

- Wrap ParseInt error in resolvePersonIDs for better diagnostics
- Add happy-path tests verifying --no-subscribe sends empty subscriptions
  array and default omits the field entirely
- Update --no-subscribe help text to "Don't subscribe anyone else" since
  the server always auto-subscribes the creator

Author: jeremy

API-COVERAGE.md

@@ -25,7 +25,7 @@ Out-of-scope sections are excluded from parity totals and scripts: chatbots (dif
 | todosets | 3 | `todosets` | ✅ | - | Container for todolists, accessed via project dock |
 | todolist_groups | 8 | `todolistgroups` | ✅ | - | list, show, create, update, position |
 | **Communication** |
-| messages | 10 | `messages`, `message` | ✅ | - | list, show, create, update, pin, unpin |
+| messages | 10 | `messages`, `message` | ✅ | - | list, show, create, update, pin, unpin. Create supports `--subscribe`/`--no-subscribe` |
 | message_boards | 3 | `messageboards` | ✅ | - | Container, accessed via project dock |
 | message_types | 5 | `messagetypes` | ✅ | - | list, show, create, update, delete |
 | campfires | 14 | `campfire` | ✅ | - | list, messages, post, line show/delete |
@@ -44,11 +44,11 @@ Out-of-scope sections are excluded from parity totals and scripts: chatbots (dif
 | **Files & Documents** |
 | uploads | 8 | `files`, `uploads` | ✅ | - | list, show |
 | vaults | 8 | `files`, `vaults` | ✅ | - | list, show, create |
-| documents | 8 | `files`, `docs` | ✅ | - | list, show, create, update |
+| documents | 8 | `files`, `docs` | ✅ | - | list, show, create, update. Create supports `--subscribe`/`--no-subscribe` |
 | attachments | 1 | `uploads` | ✅ | - | Attachment metadata |
 | **Schedule** |
 | schedules | 2 | `schedule` | ✅ | - | Schedule container + settings |
-| schedule_entries | 5 | `schedule` | ✅ | - | list, show, create, update, occurrences |
+| schedule_entries | 5 | `schedule` | ✅ | - | list, show, create, update, occurrences. Create supports `--subscribe`/`--no-subscribe` |
 | events | 1 | `events` | ✅ | - | Recording change audit trail |
 | **Webhooks** |
 | webhooks | 7 | `webhooks` | ✅ | - | list, show, create, update, delete |

go.mod

@@ -3,7 +3,7 @@ module github.com/basecamp/basecamp-cli
 go 1.26
 
 require (
-	github.com/basecamp/basecamp-sdk/go v0.0.0-20260228105634-f97b325fe599
+	github.com/basecamp/basecamp-sdk/go v0.2.2
 	github.com/charmbracelet/bubbles v1.0.0
 	github.com/charmbracelet/bubbletea v1.3.10
 	github.com/charmbracelet/glamour v0.10.0

go.sum

@@ -19,8 +19,8 @@ github.com/aymanbagabas/go-udiff v0.3.1 h1:LV+qyBQ2pqe0u42ZsUEtPiCaUoqgA9gYRDs3v
 github.com/aymanbagabas/go-udiff v0.3.1/go.mod h1:G0fsKmG+P6ylD0r6N/KgQD/nWzgfnl8ZBcNLgcbrw8E=
 github.com/aymerick/douceur v0.2.0 h1:Mv+mAeH1Q+n9Fr+oyamOlAkUNPWPlA8PPGR0QAaYuPk=
 github.com/aymerick/douceur v0.2.0/go.mod h1:wlT5vV2O3h55X9m7iVYN0TBM0NH/MmbLnd30/FjWUq4=
-github.com/basecamp/basecamp-sdk/go v0.0.0-20260228105634-f97b325fe599 h1:wev4lDLYB5vzlYLURqdu8GZYld9cJgRQNkdgFZ5HqkI=
-github.com/basecamp/basecamp-sdk/go v0.0.0-20260228105634-f97b325fe599/go.mod h1:WmckHy36EAqP+BW//1J9QdMi16l3PNx2XP0vt/kSlXE=
+github.com/basecamp/basecamp-sdk/go v0.2.2 h1:wfMrjTytLCLsBG2SrQh5UDvGgj3QHVwg6KRvkL+ayeg=
+github.com/basecamp/basecamp-sdk/go v0.2.2/go.mod h1:WmckHy36EAqP+BW//1J9QdMi16l3PNx2XP0vt/kSlXE=
 github.com/bmatcuk/doublestar v1.1.1/go.mod h1:UD6OnuiIn0yFxxA2le/rnRU1G4RaI4UvFv1sNto9p6w=
 github.com/catppuccin/go v0.3.0 h1:d+0/YicIq+hSTo5oPuRi5kOpqkVA5tAsU6dNhvRu+aY=
 github.com/catppuccin/go v0.3.0/go.mod h1:8IHJuMGaUUjQM82qBrGNBv7LFq6JI3NnQCF6MOlZjpc=

internal/commands/files.go

@@ -702,6 +702,8 @@ func newDocsCreateCmd(project, vaultID *string) *cobra.Command {
 	var title string
 	var content string
 	var draft bool
+	var subscribe string
+	var noSubscribe bool
 
 	cmd := &cobra.Command{
 		Use:   "create",
@@ -717,6 +719,12 @@ func newDocsCreateCmd(project, vaultID *string) *cobra.Command {
 				return output.ErrUsage("--title is required")
 			}
 
+			// Resolve subscription flags before project (fail fast on bad input)
+			subs, err := applySubscribeFlags(cmd.Context(), app.Names, subscribe, cmd.Flags().Changed("subscribe"), noSubscribe)
+			if err != nil {
+				return err
+			}
+
 			// Resolve project, with interactive fallback
 			projectID := *project
 			if projectID == "" {
@@ -753,8 +761,9 @@ func newDocsCreateCmd(project, vaultID *string) *cobra.Command {
 
 			// Create document using SDK
 			req := &basecamp.CreateDocumentRequest{
-				Title:   title,
-				Content: content,
+				Title:         title,
+				Content:       content,
+				Subscriptions: subs,
 			}
 			if draft {
 				req.Status = "drafted"
@@ -788,6 +797,8 @@ func newDocsCreateCmd(project, vaultID *string) *cobra.Command {
 	cmd.Flags().StringVarP(&title, "title", "t", "", "Document title (required)")
 	cmd.Flags().StringVarP(&content, "content", "c", "", "Document content")
 	cmd.Flags().BoolVar(&draft, "draft", false, "Create as draft (default: published)")
+	cmd.Flags().StringVar(&subscribe, "subscribe", "", "Subscribe specific people (comma-separated names, emails, IDs, or \"me\")")
+	cmd.Flags().BoolVar(&noSubscribe, "no-subscribe", false, "Don't subscribe anyone else (silent, no notifications)")
 	_ = cmd.MarkFlagRequired("title")
 
 	return cmd

internal/commands/files_test.go

@@ -0,0 +1,56 @@
+package commands
+
+import (
+	"errors"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+
+	"github.com/basecamp/basecamp-cli/internal/output"
+)
+
+// TestDocsCreateHasSubscribeFlags tests that docs create has --subscribe and --no-subscribe flags.
+func TestDocsCreateHasSubscribeFlags(t *testing.T) {
+	cmd := NewFilesCmd()
+
+	// Navigate: files -> documents -> create
+	docsCmd, _, err := cmd.Find([]string{"documents", "create"})
+	require.NoError(t, err)
+
+	flag := docsCmd.Flags().Lookup("subscribe")
+	require.NotNil(t, flag, "expected --subscribe flag on docs create")
+
+	flag = docsCmd.Flags().Lookup("no-subscribe")
+	require.NotNil(t, flag, "expected --no-subscribe flag on docs create")
+}
+
+// TestDocsCreateSubscribeEmptyIsError tests that --subscribe "" is rejected on docs create.
+func TestDocsCreateSubscribeEmptyIsError(t *testing.T) {
+	app, _ := setupMessagesTestApp(t)
+	app.Config.ProjectID = "123"
+
+	cmd := NewFilesCmd()
+
+	err := executeMessagesCommand(cmd, app, "documents", "create", "--title", "Test", "--subscribe", "")
+	require.Error(t, err)
+
+	var e *output.Error
+	require.True(t, errors.As(err, &e), "expected *output.Error, got %T: %v", err, err)
+	assert.Contains(t, e.Message, "at least one person")
+}
+
+// TestDocsCreateSubscribeMutualExclusion tests that --subscribe and --no-subscribe are mutually exclusive.
+func TestDocsCreateSubscribeMutualExclusion(t *testing.T) {
+	app, _ := setupMessagesTestApp(t)
+	app.Config.ProjectID = "123"
+
+	cmd := NewFilesCmd()
+
+	err := executeMessagesCommand(cmd, app, "documents", "create", "--title", "Test", "--subscribe", "me", "--no-subscribe")
+	require.Error(t, err)
+
+	var e *output.Error
+	require.True(t, errors.As(err, &e), "expected *output.Error, got %T: %v", err, err)
+	assert.Contains(t, e.Message, "mutually exclusive")
+}

internal/commands/helpers.go

@@ -4,11 +4,13 @@ import (
 	"context"
 	"encoding/json"
 	"fmt"
+	"strconv"
 	"strings"
 
 	"github.com/spf13/cobra"
 
 	"github.com/basecamp/basecamp-cli/internal/appctx"
+	"github.com/basecamp/basecamp-cli/internal/names"
 	"github.com/basecamp/basecamp-cli/internal/output"
 	"github.com/basecamp/basecamp-cli/internal/urlarg"
 )
@@ -222,3 +224,56 @@ func extractCommentWithProject(arg string) (id, projectID string) {
 func extractIDs(args []string) []string {
 	return urlarg.ExtractIDs(args)
 }
+
+// resolvePersonIDs splits a comma-separated input string and resolves each
+// token (name, email, ID, or "me") to a person ID via the name resolver.
+func resolvePersonIDs(ctx context.Context, resolver *names.Resolver, input string) ([]int64, error) {
+	var ids []int64
+	for token := range strings.SplitSeq(input, ",") {
+		token = strings.TrimSpace(token)
+		if token == "" {
+			continue
+		}
+		idStr, _, err := resolver.ResolvePerson(ctx, token)
+		if err != nil {
+			return nil, fmt.Errorf("resolving %q: %w", token, err)
+		}
+		id, err := strconv.ParseInt(idStr, 10, 64)
+		if err != nil {
+			return nil, fmt.Errorf("invalid person ID %q for %q: %w", idStr, token, err)
+		}
+		ids = append(ids, id)
+	}
+	return ids, nil
+}
+
+// applySubscribeFlags interprets --subscribe / --no-subscribe flag values and
+// returns the SDK Subscriptions pointer:
+//   - Both set → usage error (mutually exclusive)
+//   - --no-subscribe → &[]int64{} (empty list, no one else subscribed)
+//   - --subscribe "X,Y" → resolve each → &[]int64{id1, id2}
+//   - --subscribe "" (explicitly set but empty) → usage error
+//   - Neither → nil (omit, server default: everyone)
+//
+// subscribeChanged should be true when the --subscribe flag was explicitly
+// provided on the command line (i.e. cmd.Flags().Changed("subscribe")).
+func applySubscribeFlags(ctx context.Context, resolver *names.Resolver, subscribe string, subscribeChanged, noSubscribe bool) (*[]int64, error) {
+	if subscribeChanged && noSubscribe {
+		return nil, output.ErrUsage("--subscribe and --no-subscribe are mutually exclusive")
+	}
+	if noSubscribe {
+		empty := []int64{}
+		return &empty, nil
+	}
+	if subscribeChanged {
+		ids, err := resolvePersonIDs(ctx, resolver, subscribe)
+		if err != nil {
+			return nil, err
+		}
+		if len(ids) == 0 {
+			return nil, output.ErrUsage("--subscribe requires at least one person")
+		}
+		return &ids, nil
+	}
+	return nil, nil
+}

internal/commands/helpers_test.go

@@ -1,9 +1,14 @@
 package commands
 
 import (
+	"context"
+	"errors"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+
+	"github.com/basecamp/basecamp-cli/internal/output"
 )
 
 func TestIsNumeric(t *testing.T) {
@@ -36,3 +41,68 @@ func TestIsNumeric(t *testing.T) {
 		})
 	}
 }
+
+func TestApplySubscribeFlags_MutualExclusion(t *testing.T) {
+	ctx := context.Background()
+	// subscribeChanged=true, noSubscribe=true
+	_, err := applySubscribeFlags(ctx, nil, "someone", true, true)
+
+	require.Error(t, err)
+	var e *output.Error
+	require.True(t, errors.As(err, &e), "expected *output.Error, got %T", err)
+	assert.Contains(t, e.Message, "mutually exclusive")
+}
+
+func TestApplySubscribeFlags_NoSubscribe(t *testing.T) {
+	ctx := context.Background()
+	// subscribeChanged=false, noSubscribe=true
+	result, err := applySubscribeFlags(ctx, nil, "", false, true)
+
+	require.NoError(t, err)
+	require.NotNil(t, result, "expected non-nil pointer for --no-subscribe")
+	assert.Empty(t, *result, "expected empty slice for --no-subscribe")
+}
+
+func TestApplySubscribeFlags_Neither(t *testing.T) {
+	ctx := context.Background()
+	// subscribeChanged=false, noSubscribe=false
+	result, err := applySubscribeFlags(ctx, nil, "", false, false)
+
+	require.NoError(t, err)
+	assert.Nil(t, result, "expected nil when neither flag is set")
+}
+
+func TestApplySubscribeFlags_ExplicitEmptyString(t *testing.T) {
+	// --subscribe "" (explicitly set but empty value) should be a hard error
+	ctx := context.Background()
+	// subscribeChanged=true (flag was explicitly passed), value=""
+	_, err := applySubscribeFlags(ctx, nil, "", true, false)
+
+	require.Error(t, err)
+	var e *output.Error
+	require.True(t, errors.As(err, &e), "expected *output.Error, got %T", err)
+	assert.Contains(t, e.Message, "at least one person")
+}
+
+func TestApplySubscribeFlags_WhitespaceOnlyRequiresAtLeastOne(t *testing.T) {
+	ctx := context.Background()
+	// subscribeChanged=true, value=" "
+	_, err := applySubscribeFlags(ctx, nil, " ", true, false)
+
+	require.Error(t, err)
+	var e *output.Error
+	require.True(t, errors.As(err, &e), "expected *output.Error, got %T", err)
+	assert.Contains(t, e.Message, "at least one person")
+}
+
+func TestApplySubscribeFlags_CommaOnlyRequiresAtLeastOne(t *testing.T) {
+	// --subscribe ",,," should fail: only delimiters, no actual tokens
+	ctx := context.Background()
+	// subscribeChanged=true, value=",,,"
+	_, err := applySubscribeFlags(ctx, nil, ",,,", true, false)
+
+	require.Error(t, err)
+	var e *output.Error
+	require.True(t, errors.As(err, &e), "expected *output.Error, got %T", err)
+	assert.Contains(t, e.Message, "at least one person")
+}

internal/commands/messages.go

@@ -215,6 +215,8 @@ func newMessagesCreateCmd(project *string, messageBoard *string) *cobra.Command
 	var subject string
 	var content string
 	var draft bool
+	var subscribe string
+	var noSubscribe bool
 
 	cmd := &cobra.Command{
 		Use:   "create",
@@ -231,6 +233,12 @@ func newMessagesCreateCmd(project *string, messageBoard *string) *cobra.Command
 				return output.ErrUsage("--subject is required")
 			}
 
+			// Resolve subscription flags before project (fail fast on bad input)
+			subs, err := applySubscribeFlags(cmd.Context(), app.Names, subscribe, cmd.Flags().Changed("subscribe"), noSubscribe)
+			if err != nil {
+				return err
+			}
+
 			// Resolve project, with interactive fallback
 			projectID := *project
 			if projectID == "" {
@@ -265,8 +273,9 @@ func newMessagesCreateCmd(project *string, messageBoard *string) *cobra.Command
 			// Build SDK request
 			// Convert Markdown content to HTML for Basecamp's rich text fields
 			req := &basecamp.CreateMessageRequest{
-				Subject: subject,
-				Content: richtext.MarkdownToHTML(content),
+				Subject:       subject,
+				Content:       richtext.MarkdownToHTML(content),
+				Subscriptions: subs,
 			}
 
 			// Default to active (published) status unless --draft is specified
@@ -303,6 +312,8 @@ func newMessagesCreateCmd(project *string, messageBoard *string) *cobra.Command
 	cmd.Flags().StringVarP(&content, "content", "b", "", "Message body content")
 	cmd.Flags().StringVar(&content, "body", "", "Message body content (alias for --content)")
 	cmd.Flags().BoolVar(&draft, "draft", false, "Create as draft (don't publish)")
+	cmd.Flags().StringVar(&subscribe, "subscribe", "", "Subscribe specific people (comma-separated names, emails, IDs, or \"me\")")
+	cmd.Flags().BoolVar(&noSubscribe, "no-subscribe", false, "Don't subscribe anyone else (silent, no notifications)")
 	_ = cmd.MarkFlagRequired("subject")
 
 	return cmd
@@ -485,6 +496,8 @@ func NewMessageCmd() *cobra.Command {
 	var project string
 	var messageBoard string
 	var draft bool
+	var subscribe string
+	var noSubscribe bool
 
 	cmd := &cobra.Command{
 		Use:   "message",
@@ -501,6 +514,12 @@ func NewMessageCmd() *cobra.Command {
 				return output.ErrUsage("--subject is required")
 			}
 
+			// Resolve subscription flags before project (fail fast on bad input)
+			subs, err := applySubscribeFlags(cmd.Context(), app.Names, subscribe, cmd.Flags().Changed("subscribe"), noSubscribe)
+			if err != nil {
+				return err
+			}
+
 			// Resolve project, with interactive fallback
 			projectID := project
 			if projectID == "" {
@@ -535,8 +554,9 @@ func NewMessageCmd() *cobra.Command {
 			// Build SDK request
 			// Convert Markdown content to HTML for Basecamp's rich text fields
 			req := &basecamp.CreateMessageRequest{
-				Subject: subject,
-				Content: richtext.MarkdownToHTML(content),
+				Subject:       subject,
+				Content:       richtext.MarkdownToHTML(content),
+				Subscriptions: subs,
 			}
 			if draft {
 				req.Status = "drafted"
@@ -574,6 +594,8 @@ func NewMessageCmd() *cobra.Command {
 	cmd.Flags().StringVar(&project, "in", "", "Project ID (alias for --project)")
 	cmd.Flags().StringVar(&messageBoard, "message-board", "", "Message board ID (required if project has multiple)")
 	cmd.Flags().BoolVar(&draft, "draft", false, "Create as draft (don't publish)")
+	cmd.Flags().StringVar(&subscribe, "subscribe", "", "Subscribe specific people (comma-separated names, emails, IDs, or \"me\")")
+	cmd.Flags().BoolVar(&noSubscribe, "no-subscribe", false, "Don't subscribe anyone else (silent, no notifications)")
 	_ = cmd.MarkFlagRequired("subject")
 
 	return cmd