Update analytics snippet to use baseurl #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't look like specifying the page and title are really needed any more at all: https://developers.google.com/analytics/devguides/collection/analyticsjs/ |
|
I think it was never mandatory, but apparently it can improve the analytics quality, as noted in 9f23e44. |
|
Ahh yes. Thanks for the reminder. Looks like it doesn't need {{ site.baseurl }} though? It appears that you're just supposed to send the path, excluding the domain. |
|
The Google Analytics interface links back to the path, which doesn't work correctly with the baseurl; you'll get a link to |
|
I see. That's right. Thanks Mark! |
barryclark
added a commit
that referenced
this pull request
Dec 6, 2015
Update analytics snippet to use baseurl
|
Cheers! |
|
🍻 |
ymougenel
referenced
this pull request
in ymougenel/ymougenel.github.io
Apr 7, 2020
Update analytics snippet to use baseurl
pzelmanski
added a commit
to pzelmanski/pzelmanski.github.io
that referenced
this pull request
May 7, 2020
Update analytics snippet to use baseurl
pzhokhov
pushed a commit
to pzhokhov/pzhokhov.github.io
that referenced
this pull request
Jan 28, 2021
Update analytics snippet to use baseurl
rosnikv
pushed a commit
to rosnikv/rosnikv.github.io
that referenced
this pull request
Jul 30, 2022
…ate the document (barryclark#344) Co-authored-by: Neeraj Gangwar <neeraj.gangwar@myntra.com>
peppy
pushed a commit
to peppy/peppy.github.io
that referenced
this pull request
Dec 6, 2023
Update analytics snippet to use baseurl
vbmacher
pushed a commit
to vbmacher/vbmacher.github.io
that referenced
this pull request
May 26, 2024
…ark#344) Since version 3.0, Ruby has no `webrick` that Jekyll (<= 4.2) needs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.