Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disqus_identifier param is not used #126

Merged
merged 1 commit into from
Mar 1, 2015
Merged

disqus_identifier param is not used #126

merged 1 commit into from
Mar 1, 2015

Conversation

daattali
Copy link
Contributor

@daattali daattali commented Mar 1, 2015

No description provided.

@barryclark
Copy link
Owner

Hey @daattali,

Did you set your identifier in the _config.yml here? https://github.com/barryclark/jekyll-now/blob/master/_config.yml#L33-L35

That's where it gets pulled in from.

@barryclark barryclark closed this Mar 1, 2015
@daattali
Copy link
Contributor Author

daattali commented Mar 1, 2015

Thanks for taking a look so quickly.

The disqus.html template does indeed use site.disqus, but the post.html is passing another parameter as well - disqus_identifier, and I don't see that being used anywhere. Maybe it's a variable that automagically makes something work, otherwise I don't see why it's needed.

@barryclark barryclark reopened this Mar 1, 2015
@barryclark
Copy link
Owner

I must be drunk 🍺 I mistakenly thought that you'd added disqus_identifier. Thanks for the fix!

barryclark added a commit that referenced this pull request Mar 1, 2015
disqus_identifier param is not used
@barryclark barryclark merged commit 2f7f1cd into barryclark:master Mar 1, 2015
@daattali
Copy link
Contributor Author

daattali commented Mar 1, 2015

a little too early for that on the west coast, but it's good to hear some of us are having a good weekend :)

@barryclark
Copy link
Owner

😄 Thanks again for the fix, Dean!

mfeckie pushed a commit to mfeckie/mfeckie.github.io that referenced this pull request Jan 16, 2016
Fix typo/markup in theme setup page
tokka2 added a commit to tokka2/tokka2.github.io that referenced this pull request Mar 2, 2016
disqus_identifier param is not used
tonymaibox pushed a commit to tonymaibox/tonymaibox.github.io that referenced this pull request Aug 14, 2016
LarsKumbier pushed a commit to LarsKumbier/larskumbier-inactive.github.io that referenced this pull request Aug 17, 2017
Haufe Summer Practice - Android app + Alexa
ymougenel referenced this pull request in ymougenel/ymougenel.github.io Apr 7, 2020
disqus_identifier param is not used
pzelmanski added a commit to pzelmanski/pzelmanski.github.io that referenced this pull request May 7, 2020
disqus_identifier param is not used
pzhokhov pushed a commit to pzhokhov/pzhokhov.github.io that referenced this pull request Jan 28, 2021
disqus_identifier param is not used
peppy pushed a commit to peppy/peppy.github.io that referenced this pull request Dec 6, 2023
disqus_identifier param is not used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants