Add option to enable querystring in asset URLs

[slavamak]

Hi. I'm developing a solution to help reuse javascript modules in shopify theme more easily with import-maps. For example:

import { trapFocus } from 'theme.js'`

instead of

import { trapFocus } from 'https://store.myshopify.com/cdn/shop/t/13/assets/theme.e355d783.min.js'

So is there any chance that we can add an option to enable/disable this feature? This can be enabled by default, but it would be cool to be able to disable it. Because hashes are difficult to work with if we don't use the build process. For example, a developer who works with a theme directly from the store admin.

[montalvomiguelo]

Hi @slavamak (:

If we enable the version parameter. How would ES modules be imported at their latest version from generated chunks? They don't know the version parameter generated via asset_url/Liquid.

[slavamak]

Thanks Miguel! In fact in the spec I didn't find mention something about css files, so I guess it's not a problem, but I'm not 100% sure. I added a <base> tag and also added import.meta.resolve which automatically resolves the url for module specifire and solves the second problem. It seems to work like a charm :) but we need to test this, also requires polyfill for this, but I think it's not a problem

[montalvomiguelo]

@slavamak I saw those updates and the playground. Very cool stuff! 🚀
The CSS piece is tricky, AFIK import-maps are primarily designed for managing JS module dependencies.

[slavamak]

@montalvomiguelo Yes right, and it's weird, yet it also works with css and images. Maybe it's a bug? 😁

[montalvomiguelo]

@slavamak I'll add the flexibility of enabling the version parameter through the versionNumbers option. The value of your plugin will be very beneficial in the Shopify theme dev space (:
cc @wturnerharris

[montalvomiguelo]

@slavamak @wturnerharris, I added the versionNumbers option in #99 (:

[jonathanmoore]

I would love to see @slavamak's idea expanded and an option we could use. From a premium theme's perspective I would be 99% certain Shopify's review process would flag and decline any theme submission that breaks the native asset_url filter and Shopify's use of cache variables.

[slavamak]

This is already being used in the theme store, so I guess breaks the native asset_url filter not a problem :) You can check Paper theme and toolkit

[tylerhellner]

I would love to use @slavamak's plugin as well! Keep us posted if you're ever thinking about integrating it with this setup.