-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github: introduce template for issues #1716
Conversation
7098c9f
to
9396eaf
Compare
dfc5734
to
c8bdad3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some comments.
description: What version of Bareos are you seeing the problem on? | ||
options: | ||
- 23x | ||
- 24x | ||
- Others | ||
default: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should set
multiple: true
here, since an issue might be possible on multiple different bareos issues.
Maybe we should also expand Others to 22,21,..., having at least all supported versions explicitly listed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really happy with having numeric versions here at all. It will mean that we will have to change the template as part of every major release which adds yet another item to the release manager TODO list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the last idea would be to benefit of a direct link between an issues and the version to have this field as textarea fill'up by the user. That mean he can report component with mixed version and we will have the exact version including git and ~pre ....
I will propose another field for that.
prove a divergence with the documentation, and/or a crash (trace) that are | ||
somewhat reproducible. | ||
|
||
We always recommend to start discussing your issue on the mailing list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we also want to add something like
- type: input
id: contact
attributes:
label: Contact Details
description: How can we get in touch with you if we need more info?
placeholder: ex. email@example.com
validations:
required: false
f526d9e
to
6c7de08
Compare
7f894c1
to
8a09049
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're like 99% there already. Good work!
description: What version of Bareos are you seeing the problem on? | ||
options: | ||
- 23x | ||
- 24x | ||
- Others | ||
default: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really happy with having numeric versions here at all. It will mean that we will have to change the template as part of every major release which adds yet another item to the release manager TODO list.
- add ISSUE_TEMPLATE/config.yaml - add ISSUE_TEMPLATE/10-issue_report.yaml for bugs - add ISSUE_TEMPLATE/20-feature_request.yaml for feature - add workflows/no-response.yaml no-response action - we don't do line wrap so they will adapt to github rendering page - we use labels of predefined defaults: beside `needs triage`, we prefill with `bug` or `enhancement` as it is easier to remove a label than adding one - we use `render: sh` for log,trace textareas so there's no need to use backtick syntax Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
- reformat long lines - remove contributing patches by email Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
642ac1d
to
eec4cac
Compare
Thank you for contributing to the Bareos Project!
This PR will introduce our first templates for creating issues on github.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-tool
to have some simple automated checks run and a proper changelog record added.General