cleaned up super-obscure bug caused by trying to call debuggit() from inside _set_debuggit_func()

Buddy Burden · Buddy Burden · commit 6c6ef0464fa6 · 2009-07-11T09:36:02.000Z
not only avoids spurious warning, but should provide better performance as well
diff --git a/Barefoot/Barefoot.pm b/Barefoot/Barefoot.pm
@@ -163,8 +163,8 @@ sub _set_debuggit_func
 {
 	my ($caller_package, $debug_value) = @_;
 
-	my $caller_loaded = defined eval qq{ ${caller_package}::debuggit(); 1; };
-	# print STDERR "Debuggit loaded is $Debuggit_loaded\n";
+	my $caller_loaded = $caller_package->can('debuggit');
+	# print STDERR "caller loaded is $caller_loaded\n";
 	return if $caller_loaded;
 
 	my $Debuggit_loaded = defined eval qq{ Debuggit::DEBUG(); };

Original file line number	Diff line number	Diff line change
`@@ -163,8 +163,8 @@ sub _set_debuggit_func`
`163`	`163`	`{`
`164`	`164`	`my ($caller_package, $debug_value) = @_;`
`165`	`165`
`166`		`- my $caller_loaded = defined eval qq{ ${caller_package}::debuggit(); 1; };`
`167`		`- # print STDERR "Debuggit loaded is $Debuggit_loaded\n";`
	`166`	`+ my $caller_loaded = $caller_package->can('debuggit');`
	`167`	`+ # print STDERR "caller loaded is $caller_loaded\n";`
`168`	`168`	`return if $caller_loaded;`
`169`	`169`
`170`	`170`	`my $Debuggit_loaded = defined eval qq{ Debuggit::DEBUG(); };`