Merge branch 'bane-main' into upd-v1.13.15

Author: AnnaShaleva

CHANGELOG.md

@@ -2,6 +2,99 @@
 
 This document outlines major changes between releases.
 
+## 0.2.1 "Graphitization" (24 Jul 2024)
+
+A patch version compatible with v0.2.0 release of Neo X node that brings a set of
+minor compatible improvements and bug fixes to system contracts, dBFT consensus
+engine and RPC APIs. This version is aimed to be run on the initial version of Neo X
+MainNet.
+
+A new `config/genesis_mainnet.json` configuration file is added, please use this file
+to initialize a database for MainNet nodes. Ensure your MainNet node running script
+contains an updated network ID (`47763`) and a proper MainNet bootnode identifiers
+set. For T4 node operators it should be noted that this release does not require a DB
+resynchronisation. However, we recommend to update the node binary since it contains
+a dBFT-related bug fix that may affect the consensus functionality in a very specific
+set of conditions.
+
+New features:
+ * Multisignature system contract aimed to serve as an owner of Bridge and Bridge
+   Management system contracts instead of a simple EOA account (#279)
+ * genesis configuration for Neo X MainNet (#271)
+
+Behavior changes:
+ * initial candidate registration fee is lowered down to 1000 GAS in Governance
+   system contract (#275, #281)
+ * candidate exit fee ratio is increased up to 50% from the deposited value in
+   Governance system contract (#275, #280, #281) 
+
+Improvements:
+ * disable initialization code for every UUPS implementation (#259)
+ * Bridge and Bridge Management system contracts update (#274)
+
+Bugs fixed:
+ * missing total votes update on transferring votes from exited candidate in
+   Governance system contract (#260)
+ * non-strict GovernanceVote system contract check for the number of voters (#267)
+ * improper GAS estimation in `eth_estimateGas` Blockchain RPC API caused by changes
+   in fee policies of Neo X (#263)
+ * missing track of miner's work resume event which leads to dBFT hanging on next
+   block awaiting when miner is suspended due to the node sync (#268)
+
+
+## 0.2.0 "Vitaminization" (10 Jul 2024)
+
+A minor long-term supported version bringing new NeoXBurn hardfork that enables
+Policy-based transaction fees burning instead of dynamically evaluated fees of
+EIP-1559. This version contains compatible protocol extensions (transactions
+reannouncement mechanism), a set of enhanced system contract improvements
+(consensus candidates limit restrictions, registration deposit fee, voting transfer
+functionality, new Treasury system contract and more) and documentation upgrades.
+Additionally, as a result of security audit, this version contains a set of
+enhancements and stability/safety fixes for system contracts and dBFT protocol.
+This version is still based on v1.13.11 Geth implementation with Shanghai hardfork
+supported as the latest one.
+
+This version is aimed to be run on a fresh Neo X T4 network. Please, ensure your node
+configuration includes the NeoXBurn hardfork, an upgraded network ID and all genesis
+allocations properly set. A new database should be initialized for this version, it's
+not compatible with an existing Neo X T3 testnet.
+
+New features:
+ * Treasury system contract aimed to fund Bridge operations (#184, #236)
+ * reannouncement mechanism for pending mempooled transactions (#194)
+ * reserved system contracts support (#236)
+
+Behavior changes:
+ * limit the number of candidates via Policy system contract (#216, #238)
+ * NeoXBurn hardfork introducing BaseFee burning based on the Policy system contract
+   setting (#166, #230, #249)
+ * time lock is added for system contracts upgrade (#245)
+ * 5% deposit fee is charged by Governance on candidate exiting from the Governance
+   candidates list (#247)
+ * candidate registration fee is increased from 1000 up to 20000 GAS (#236)
+
+Improvements:
+ * system contracts documentation updates (#173, #236)
+ * `transferVote` method added to the Governance system contract (#182)
+ * updated dBFT library dependency (#185)
+ * optimize execution cost of system contracts (#195)
+ * better event indexing for system contracts (#196)
+ * Solidity compiler version upgraded for system contracts (#208)
+ * improved error reporting for system contracts (#209)
+ * better unit-test coverage for system contracts (#210, #211, #214, #215, #223)
+ * clear votes for method call once enough votes are collected in GovernanceVote
+   system contract (#227)
+ * system contracts stability improvements (#217, #221, #241)
+
+Bugs fixed:
+ * reentrancy problem in GovernanceVote system contract (#195)
+ * potential division by zero in Governance system contract (#225)
+ * OnPersist system call processing missed in t8ntool execution flow (#229)
+ * blacklisted accounts are allowed to be elected as consensus members (#242)
+ * dBFT protocol payloads are not verified against consensus members by non-consensus
+   nodes (#243)
+
 ## 0.1.1 "Backdating" (18 April 2024)
 
 An urgent patch release to fix the bug in T3 genesis configuration file introduced in 0.1.0.

Makefile

@@ -2,7 +2,7 @@
 # with Go source code. If you know what GOPATH is then you probably
 # don't need to bother with make.
 
-.PHONY: geth android ios evm all test clean privnet_init privnet_nodes_stop privnet_bootnode_stop privnet_stop privnet_clean privnet_start privnet_start_four privnet_start_seven
+.PHONY: geth android ios evm all test clean privnet_nodes_stop privnet_bootnode_stop privnet_stop privnet_clean privnet_start privnet_start_four privnet_start_seven
 
 GETHBIN = ./build/bin
 GO ?= latest
@@ -71,33 +71,6 @@ BOOTNODE_LOGLEVEL = 5
 RESTRICTED_NETWORK = 127.0.0.0/24
 NAT_POLICY = none
 
-define generate_bootnode
-	@mkdir -p $(1)/$(BOOTNODE)
-	@$(GETHBIN)/bootnode -genkey $(1)/$(BOOTNODE)/bootnode.key
-	@echo $$($(GETHBIN)/bootnode --writeaddress -nodekey $(1)/$(BOOTNODE)/bootnode.key) > $(1)/$(BOOTNODE)/bootnode_address.txt
-endef
-
-define generate_password
-   $$(</dev/urandom tr -dc '12345qwertQWERTasdfgASDFGzxcvbZXCVB' | head -c$(PASSWORD_LEN); echo "")
-endef
-
-define replace_chainid
-	@sed -i "s/_chain_id_/$$(cat $(1)/networkid.txt)/gI" $(1)/$(GENESIS_WORK_JSON)
-endef
-
-define replace_node_address
-	@echo $$(cat $(1)/$(2)/keystore/* | sed -En 's/.*"address":"([^"]*).*/\1/p') > $(1)/$(2)/node_address.txt
-	@sed -i "s/$(2)/$$(cat $(1)/$(2)/node_address.txt)/gI" $(1)/$(GENESIS_WORK_JSON)
-endef
-
-define create_account
-    @mkdir -p $(1)/$(2)
-    @echo $(call generate_password) > $(1)/$(2)/password.txt
-    @$(GETHBIN)/geth --datadir $(1)/$(2) account new --password $(1)/$(2)/password.txt
-    $(call replace_node_address,$(1),$(2))
-    @echo "Account $(1): "$$(cat $(1)/$(2)/node_address.txt)
-endef
-
 define run_bootnode
     @$(GETHBIN)/bootnode -nodekey $(1)/$(BOOTNODE)/bootnode.key \
     	-addr :$(BOOTNODE_PORT) \
@@ -171,60 +144,6 @@ devtools:
 
 # Privnet targets
 
-privnet_init: privnet_clean
-	@find $(SINGLE_DIR)/* -type d -name 'keystore' -exec rm -rf {} +
-	@mkdir -p $(SINGLE_DIR)
-	@echo "Generate  $(GENESIS_WORK_JSON) file"
-	@cp $(SINGLE_DIR)/genesis_template.json $(SINGLE_DIR)/$(GENESIS_WORK_JSON)
-	@echo $$(date +'%y%m%d%H%M') > $(SINGLE_DIR)/networkid.txt
-	@echo "Network ID is "$$(cat $(SINGLE_DIR)/networkid.txt)
-	@echo "Generate bootnode"
-	$(call generate_bootnode,$(SINGLE_DIR))
-	$(call replace_chainid,$(SINGLE_DIR))
-	@echo "Create accounts"
-	$(call create_account,$(SINGLE_DIR),$(NODE1))
-	$(call create_account,$(SINGLE_DIR),$(NODE2))
-	@echo "OK! For starting use 'make privnet_start'"
-
-privnet_init_four: privnet_clean
-	@find $(FOUR_DIR)/* -type d -name 'keystore' -exec rm -rf {} +
-	@mkdir -p $(FOUR_DIR)
-	@echo "Generate  $(GENESIS_WORK_JSON) file"
-	@cp $(FOUR_DIR)/genesis_template.json $(FOUR_DIR)/$(GENESIS_WORK_JSON)
-	@echo $$(date +'%y%m%d%H%M') > $(FOUR_DIR)/networkid.txt
-	@echo "Network ID is "$$(cat $(FOUR_DIR)/networkid.txt)
-	@echo "Generate bootnode"
-	$(call generate_bootnode,$(FOUR_DIR))
-	$(call replace_chainid,$(FOUR_DIR))
-	@echo "Create accounts"
-	$(call create_account,$(FOUR_DIR),$(NODE1))
-	$(call create_account,$(FOUR_DIR),$(NODE2))
-	$(call create_account,$(FOUR_DIR),$(NODE3))
-	$(call create_account,$(FOUR_DIR),$(NODE4))
-	$(call create_account,$(FOUR_DIR),$(NODE5))
-	@echo "OK! For starting use 'make privnet_start_four'"
-
-privnet_init_seven: privnet_clean
-	@find $(SEVEN_DIR)/* -type d -name 'keystore' -exec rm -rf {} +
-	@mkdir -p $(SEVEN_DIR)
-	@echo "Generate  $(GENESIS_WORK_JSON) file"
-	@cp $(SEVEN_DIR)/genesis_template.json $(SEVEN_DIR)/$(GENESIS_WORK_JSON)
-	@echo $$(date +'%y%m%d%H%M') > $(SEVEN_DIR)/networkid.txt
-	@echo "Network ID is "$$(cat $(SEVEN_DIR)/networkid.txt)
-	@echo "Generate bootnode"
-	$(call generate_bootnode,$(SEVEN_DIR))
-	$(call replace_chainid,$(SEVEN_DIR))
-	@echo "Create accounts"
-	$(call create_account,$(SEVEN_DIR),$(NODE1))
-	$(call create_account,$(SEVEN_DIR),$(NODE2))
-	$(call create_account,$(SEVEN_DIR),$(NODE3))
-	$(call create_account,$(SEVEN_DIR),$(NODE4))
-	$(call create_account,$(SEVEN_DIR),$(NODE5))
-	$(call create_account,$(SEVEN_DIR),$(NODE6))
-	$(call create_account,$(SEVEN_DIR),$(NODE7))
-	$(call create_account,$(SEVEN_DIR),$(NODE8))
-	@echo "OK! For starting use 'make privnet_start_seven'"
-
 privnet_nodes_stop:
 	@echo "Killing nodes processes"
 	@killall -w -v -INT geth || :