Apply setMaxLifecycle during fragment transaction & update dependencies #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gildor
reviewed
Apr 1, 2022
| @@ -275,6 +278,13 @@ class FragNavController constructor(private val fragmentManger: FragmentManager, | |||
| } else { | |||
| //Attempt to reattach previous fragment | |||
| fragment = addPreviousFragment(ft, shouldDetachAttachOnSwitch() || shouldRemoveAttachOnSwitch()) | |||
|
|
|||
| fragmentCache.values.forEach { ref -> | |||
There was a problem hiding this comment.
Should it be an option to set max lifecycle? Without this it will change behaviour of existing apps
There was a problem hiding this comment.
Right, good catch 👍 Will deal with it
mrahimygk
approved these changes
Apr 1, 2022
gildor
approved these changes
Apr 4, 2022
frag-nav/src/test/java/com/ncapdevi/fragnav/tabhistory/UnlimitedTabHistoryControllerTest.kt
Outdated
Show resolved
Hide resolved
frag-nav/src/test/java/com/ncapdevi/fragnav/tabhistory/UniqueTabHistoryControllerTest.kt
Outdated
Show resolved
Hide resolved
gildor
reviewed
Apr 4, 2022
frag-nav/src/main/java/com/ncapdevi/fragnav/FragNavController.kt
Outdated
Show resolved
Hide resolved
gildor
approved these changes
Apr 4, 2022
kevinguitar
force-pushed
the
apply-max-lifecycle
branch
from
e245b01 to
ec9ec14
Compare
gildor
approved these changes
Apr 5, 2022
|
|
||
| # https://github.com/kt3k/coveralls-gradle-plugin/issues/85 | ||
| systemProp.jdk.tls.client.protocols="TLSv1,TLSv1.1,TLSv1.2" |
There was a problem hiding this comment.
Ehh, it's not very nice, it makes connection less secure, but I think we have no way to fix it without changing code coverage service
kevinguitar
added a commit
that referenced
this pull request
Apr 5, 2022
…es (#2) * Apply setMaxLifecycle during fragment transaction & update dependencies * Updated travis config * Deprecated few properties + adjust publishing config * Update .travis.yml * Update .travis.yml * Update .travis.yml * Update .travis.yml * Update .travis.yml * Update .travis.yml * Add an option to set max lifecycle * Fix some lint warning * Fix missing dependency in test * Address review comments * Update jacoco report path * Workaround for coveralls SSLException Co-authored-by: Andrey Mischenko <gildor@users.noreply.github.com>
kevinguitar
added a commit
that referenced
this pull request
Apr 5, 2022
…es (#2) * Apply setMaxLifecycle during fragment transaction & update dependencies * Updated travis config * Deprecated few properties + adjust publishing config * Update .travis.yml * Update .travis.yml * Update .travis.yml * Update .travis.yml * Update .travis.yml * Update .travis.yml * Add an option to set max lifecycle * Fix some lint warning * Fix missing dependency in test * Address review comments * Update jacoco report path * Workaround for coveralls SSLException Co-authored-by: Andrey Mischenko <gildor@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
There's a known issue that if you use the hiding strategy on the fragment switch, the fragment's lifecycle won't be changed.
However, there's a new setMaxLifecycle function been added in the
FragmentTransactionwhich can set the maximum lifecycle state during the transaction, andViewPager2.FragmentStateAdapteractually has such implementation.Bringing this function call to the library for the hiding strategy, so the fragment lifecycle will be triggered properly during switching.
What have been changed in this PR: