Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bamarni/symfony-console-autocomplete
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.5.5
Choose a base ref
...
head repository: bamarni/symfony-console-autocomplete
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 2 commits
  • 4 files changed
  • 1 contributor

Commits on Dec 24, 2022

  1. chore(ci): fix cached typo 

    it is "cache" not "cached".  adding "*" for clean of "vendor-*.cache*"
(previously /.cached$/) to retain backwards compatibility (the "*" at the
end can be removed safely later in time).

rationale: "cached" is not at build time in general, and within this
project also for files within the repository, e.g.

- resources/bash/cached.php
- tests/fixtures/bash/cached.txt
    @ktomk
    ktomk committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    f7c0779 View commit details
    Browse the repository at this point in the history

  2. fix symfony-autocomplete composer vendor 

    bin/symfony-autocomplete did not honor COMPOSER_VENDOR_DIR and treated it
as if it is the default value "vendor" only.

however it is part of the composer install protocol and required for
the bin-stubs autoloading.  it should not be hard-encoded to the default
value only.

fix is to use COMPOSER_VENDOR_DIR as absolute path, as relative path to
PWD and as relative path to bin/symfony-autocomplete given the first
attempt to try requiring from __DIR__.'/../../../autoload.php' failed.

NOTE: use of include_once instead of require_once is intended here, the EA
      inspection is misleading on it as _once was and still is intended.

this is similar for "acme" in tests, but with the difference that during
build time we insist to know that COMPOSER_VENDOR_DIR is always relative
to the project root, YMMV.

report: #76
    @ktomk
    ktomk committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    fa77f35 View commit details
    Browse the repository at this point in the history
Loading