fix(GitOpsConfig): prevent namespace >63

Author: christiansiegel

gitopscli/gitops_config.py

@@ -111,6 +111,14 @@ def get_preview_namespace(self, preview_id: str) -> str:
 
         current_length = len(preview_namespace) - len("{PREVIEW_ID}")
         remaining_length = _MAX_NAMESPACE_LENGTH - current_length
+
+        if remaining_length < 1:
+            preview_namespace = preview_namespace.replace("{PREVIEW_ID}", "")
+            raise GitOpsException(
+                f"Preview namespace is too long (max {_MAX_NAMESPACE_LENGTH} chars): "
+                f"{preview_namespace} ({len(preview_namespace)} chars)"
+            )
+
         sanitized_preview_id = self.__sanitize(preview_id, remaining_length)
 
         preview_namespace = preview_namespace.replace("{PREVIEW_ID}", sanitized_preview_id)

tests/test_gitops_config_v1.py

@@ -227,6 +227,18 @@ def test_preview_target_namespace_invalid_template(self):
             config.get_preview_namespace("preview-1")
         self.assertEqual("Invalid character in preview namespace: '*'", str(ex.value))
 
+    def test_preview_target_namespace_too_long(self):
+        self.yaml["previewConfig"]["target"][
+            "namespace"
+        ] = "veeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeery-long-{PREVIEW_ID}-{PREVIEW_ID_HASH}"
+        config = self.load()
+        with pytest.raises(GitOpsException) as ex:
+            config.get_preview_namespace("x")
+        self.assertEqual(
+            "Preview namespace is too long (max 63 chars): veeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeery-long--2d711642 (68 chars)",
+            str(ex.value),
+        )
+
     def test_preview_target_namespace_contains_invalid_variable(self):
         self.yaml["previewConfig"]["target"]["namespace"] = "{FOO}-bar"
         self.assert_load_error("GitOps config template '{FOO}-bar' contains invalid variable: FOO")