Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when pruning is skipped #28

Open
micahjsmith opened this issue Jul 1, 2021 · 0 comments
Open

Error when pruning is skipped #28

micahjsmith opened this issue Jul 1, 2021 · 0 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@micahjsmith
Copy link
Contributor

When a user has disabled the pruning job, the bot has an error:

TypeError: Cannot read property '2' of undefined
  File "/app/lib/travis.js", line 73, in getJobLogFromBuild
    const prunerJob = build.jobs[jobNum];
  File "/app/lib/travis.js", line 35, in Object.getTravisAcceptanceMetadata
    const acceptanceLog = await getJobLogFromBuild(
  File "/app/index.js", line 72, in null.
    const { omittedFeature } = travis.getTravisAcceptanceMetadata(travisBuildId);

Suggested behavior:

  • the bot checks the job exists before trying to get the job log
@micahjsmith micahjsmith added bug Something isn't working help wanted Extra attention is needed labels Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant