Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip - Update match schema #2672

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

wip - Update match schema #2672

wants to merge 1 commit into from

Conversation

Omri-Levy
Copy link
Contributor

@Omri-Levy Omri-Levy commented Sep 2, 2024 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features

    • No new features introduced in this release.

  • Bug Fixes

    • Minor updates to dependencies across various packages, potentially enhancing functionality and performance.

  • Documentation

    • Updated changelogs for multiple packages to reflect new version entries and dependency updates.

  • Chores

    • Incremented version numbers for several packages to indicate minor updates and maintenance.

  • Refactor

    • Minor cosmetic changes made to improve code readability without affecting functionality.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 2, 2024

⚠️ No Changeset found

Latest commit: f56b7dd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 2, 2024 •
edited
Loading

Walkthrough

The updates encompass several packages within the Ballerine ecosystem, primarily focusing on version increments and dependency updates. Notably, the @ballerine/common package has been updated to version 0.9.28, along with various other dependencies across multiple applications and services. Additionally, minor schema modifications have been made to enhance flexibility in the MerchantMatchSchema and MerchantSchema. Overall, these changes reflect routine maintenance and improvements across the project.

Changes

File(s) Change Summary
apps/backoffice-v2/CHANGELOG.md, apps/backoffice-v2/package.json Updated @ballerine/backoffice-v2 to version 0.7.38, with dependency updates to @ballerine/common (0.9.28), @ballerine/workflow-browser-sdk (0.6.39), and @ballerine/workflow-node-sdk (0.6.39).
apps/kyb-app/CHANGELOG.md, apps/kyb-app/package.json Updated kyb-app to version 0.3.46, with dependency updates to @ballerine/common (0.9.28) and @ballerine/workflow-browser-sdk (0.6.39).
examples/headless-example/CHANGELOG.md, examples/headless-example/package.json Updated @ballerine/headless-example to version 0.3.38, with dependency updates to @ballerine/common (0.9.28) and @ballerine/workflow-browser-sdk (0.6.39).
packages/common/CHANGELOG.md, packages/common/package.json Updated @ballerine/common to version 0.9.28, with a patch change to the match schema.
packages/common/src/schemas/documents/merchant-screening-plugin-schema.ts Modified properties in MerchantMatchSchema to be optional and changed Address in MerchantSchema to mandatory.
packages/workflow-core/CHANGELOG.md, packages/workflow-core/package.json Updated @ballerine/workflow-core to version 0.6.39, with a dependency update to @ballerine/common (0.9.28).
sdks/web-ui-sdk/CHANGELOG.md, sdks/web-ui-sdk/package.json Updated @ballerine/web-ui-sdk to version 1.5.29, with a dependency update to @ballerine/common (0.9.28).
sdks/workflow-browser-sdk/CHANGELOG.md, sdks/workflow-browser-sdk/package.json Updated @ballerine/workflow-browser-sdk to version 0.6.39, with dependency updates to @ballerine/common (0.9.28) and @ballerine/workflow-core (0.6.39).
sdks/workflow-node-sdk/CHANGELOG.md, sdks/workflow-node-sdk/package.json Updated @ballerine/workflow-node-sdk to version 0.6.39, with a dependency update to @ballerine/workflow-core (0.6.39).
services/workflows-service/CHANGELOG.md, services/workflows-service/package.json Updated @ballerine/workflows-service to version 0.7.38, with dependency updates to @ballerine/common (0.9.28), @ballerine/workflow-core (0.6.39), and @ballerine/workflow-node-sdk (0.6.39).
services/workflows-service/prisma/data-migrations Updated subproject commit identifier.
services/workflows-service/src/alert/alert.service.ts Minor cosmetic change to improve code readability.
websites/docs/package.json Updated @ballerine/common dependency version from ^0.9.27 to ^0.9.28.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant App
    participant Common
    participant WorkflowSDK

    User->>App: Request action
    App->>Common: Use common functionality
    Common-->>App: Return data
    App->>WorkflowSDK: Execute workflow
    WorkflowSDK-->>App: Return workflow result
    App-->>User: Display result
Loading

🐰 Hopping through the code with glee,
New versions make us jump with glee!
Dependencies fresh, schemas refined,
In the world of Ballerine, joy we find!
So let’s celebrate, with a hop and a cheer,
For every update brings us near! 🎉

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.
Early access features: disabled

We are currently testing the following features in early access:

  • Anthropic claude-3-5-sonnet for code reviews: Anthropic claims that the new Claude model has stronger code understanding and code generation capabilities than their previous models. Note: Our default code review model was also updated late last week. Please compare the quality of the reviews between the two models by toggling the early access feature.

Note:

  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
  • Please join our Discord Community to provide feedback and report issues on the discussion post.

coderabbitai[bot]
coderabbitai bot reviewed Sep 2, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between dc4e7b4 and f56b7dd.

Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
Files selected for processing (22)
  • apps/backoffice-v2/CHANGELOG.md (1 hunks)
  • apps/backoffice-v2/package.json (2 hunks)
  • apps/kyb-app/CHANGELOG.md (1 hunks)
  • apps/kyb-app/package.json (2 hunks)
  • examples/headless-example/CHANGELOG.md (1 hunks)
  • examples/headless-example/package.json (2 hunks)
  • packages/common/CHANGELOG.md (1 hunks)
  • packages/common/package.json (1 hunks)
  • packages/common/src/schemas/documents/merchant-screening-plugin-schema.ts (2 hunks)
  • packages/workflow-core/CHANGELOG.md (1 hunks)
  • packages/workflow-core/package.json (2 hunks)
  • sdks/web-ui-sdk/CHANGELOG.md (1 hunks)
  • sdks/web-ui-sdk/package.json (2 hunks)
  • sdks/workflow-browser-sdk/CHANGELOG.md (1 hunks)
  • sdks/workflow-browser-sdk/package.json (2 hunks)
  • sdks/workflow-node-sdk/CHANGELOG.md (1 hunks)
  • sdks/workflow-node-sdk/package.json (2 hunks)
  • services/workflows-service/CHANGELOG.md (1 hunks)
  • services/workflows-service/package.json (2 hunks)
  • services/workflows-service/prisma/data-migrations (1 hunks)
  • services/workflows-service/src/alert/alert.service.ts (1 hunks)
  • websites/docs/package.json (1 hunks)
Files skipped from review due to trivial changes (21)
  • apps/backoffice-v2/CHANGELOG.md
  • apps/backoffice-v2/package.json
  • apps/kyb-app/CHANGELOG.md
  • apps/kyb-app/package.json
  • examples/headless-example/CHANGELOG.md
  • examples/headless-example/package.json
  • packages/common/CHANGELOG.md
  • packages/common/package.json
  • packages/workflow-core/CHANGELOG.md
  • packages/workflow-core/package.json
  • sdks/web-ui-sdk/CHANGELOG.md
  • sdks/web-ui-sdk/package.json
  • sdks/workflow-browser-sdk/CHANGELOG.md
  • sdks/workflow-browser-sdk/package.json
  • sdks/workflow-node-sdk/CHANGELOG.md
  • sdks/workflow-node-sdk/package.json
  • services/workflows-service/CHANGELOG.md
  • services/workflows-service/package.json
  • services/workflows-service/prisma/data-migrations
  • services/workflows-service/src/alert/alert.service.ts
  • websites/docs/package.json
Additional comments not posted (8)
packages/common/src/schemas/documents/merchant-screening-plugin-schema.ts (8)

150-156: LGTM!

The code changes are approved.

157-162: LGTM!

The code changes are approved.

167-172: LGTM!

The code changes are approved.

173-179: LGTM!

The code changes are approved.

180-186: LGTM!

The code changes are approved.

187-193: LGTM!

The code changes are approved.

194-200: LGTM!

The code changes are approved.

229-229: LGTM, but verify the impact of making the Address field mandatory.

The code changes are approved. However, since the Address field is now mandatory, ensure that all the code paths that create or update the MerchantSchema provide an address. Verify that this change does not break any existing functionality.

Run the following script to verify the usage of MerchantSchema:

@Omri-Levy Omri-Levy changed the title Update match schema wip - Update match schema Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Omri-Levy