-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual Studio Code gitignore + recommended extensions #2581
Conversation
|
Oops, didn't realise that square brackets are service tags. |
One thing that might be worth considering adding to the repo (and would thus require an additional negated pattern in the .gitignore) would be recommended VS Code extensions for working on the Shields code base (https://code.visualstudio.com/docs/editor/extension-gallery#_workspace-recommended-extensions) For example:
That way if a user decides to use VS Code to work on the Shields code then they can see/install/enable those project recommended extensions easily |
Maybe also add https://marketplace.visualstudio.com/items?itemName=tombonnike.vscode-status-bar-format-toggle too? Description: |
Thanks so much for putting this together! I'd propose the below list of extensions for consideration, imagine others will have some thoughts as well. I think I'd advise against the format toggle extension. The Shields codebase uses prettier extensively, and PRs/changes that don't conform to that standard will fail/be rejected. As such I think for the Shields codebase in particular we'd want to recommend prettier and not recommend something to disable prettier since these are workspace/project specific recommendations.
Maybe gitlens or some of the snippet extensions, or ones for React, html/css, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this as-is with the current 3 recommended extensions (prettier, editorconfig, and eslint). We can add other extensions at a later date if and when we decide we want them.
Thanks @Prouser123!
.vscode
(workspace settings directory) to the gitignore.