Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Studio Code gitignore + recommended extensions #2581

Merged
merged 4 commits into from
Dec 29, 2018

Conversation

jcxldn
Copy link
Contributor

@jcxldn jcxldn commented Dec 23, 2018

  • Added .vscode (workspace settings directory) to the gitignore.

@shields-ci
Copy link

shields-ci commented Dec 23, 2018

Messages
📖 ✨ Thanks for your contribution to Shields, @Prouser123!

Generated by 🚫 dangerJS against e4fb47d

@jcxldn jcxldn changed the title [gitignore] Add Visual Studio Code Add Visual Studio Code to the gitignore. Dec 23, 2018
@jcxldn
Copy link
Contributor Author

jcxldn commented Dec 23, 2018

Oops, didn't realise that square brackets are service tags.

@calebcartwright calebcartwright added the developer-experience Dev tooling, test framework, and CI label Dec 24, 2018
@calebcartwright
Copy link
Member

One thing that might be worth considering adding to the repo (and would thus require an additional negated pattern in the .gitignore) would be recommended VS Code extensions for working on the Shields code base (https://code.visualstudio.com/docs/editor/extension-gallery#_workspace-recommended-extensions) For example:

That way if a user decides to use VS Code to work on the Shields code then they can see/install/enable those project recommended extensions easily

@jcxldn jcxldn changed the title Add Visual Studio Code to the gitignore. Visual Studio Code gitignore + recommended extensions Dec 24, 2018
@jcxldn
Copy link
Contributor Author

jcxldn commented Dec 24, 2018

Maybe also add https://marketplace.visualstudio.com/items?itemName=tombonnike.vscode-status-bar-format-toggle too?

Description:
A VS Code extension that allows you to toggle the formatter (Prettier, Beautify, …) ON and OFF with a simple click.

@calebcartwright
Copy link
Member

calebcartwright commented Dec 24, 2018

Thanks so much for putting this together!

I'd propose the below list of extensions for consideration, imagine others will have some thoughts as well. I think I'd advise against the format toggle extension. The Shields codebase uses prettier extensively, and PRs/changes that don't conform to that standard will fail/be rejected. As such I think for the Shields codebase in particular we'd want to recommend prettier and not recommend something to disable prettier since these are workspace/project specific recommendations.

Maybe gitlens or some of the snippet extensions, or ones for React, html/css, etc.

Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this as-is with the current 3 recommended extensions (prettier, editorconfig, and eslint). We can add other extensions at a later date if and when we decide we want them.

Thanks @Prouser123!

@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer-experience Dev tooling, test framework, and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants