Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link directly to builder modals #7064

Closed
chris48s opened this issue Sep 25, 2021 · 3 comments
Closed

Link directly to builder modals #7064

chris48s opened this issue Sep 25, 2021 · 3 comments
Labels
frontend The Docusaurus app serving the docs site

Comments

@chris48s
Copy link
Member

📋 Description

It would be really nice if the builder modal for each badge had its own URL. So for example if I wanted to link someone straight to

Screenshot at 2021-09-25 16-09-25

I could use https://shields.io/category/build#appveyor/build or https://shields.io/builder/appveyor/build or something (exact implementation details TBD) and that would load the site with that builder modal open.

@chris48s chris48s added the frontend The Docusaurus app serving the docs site label Sep 25, 2021
@paulmelnikow
Copy link
Member

Agree this would be a good idea. Lots of possibilities there. Something like https://shields.io/appveyor/build would be pretty cool, though maybe something like https://shields.io/builder/appveyor/build or https://shields.io/services/appveyor/build would be safer. Should definitely be thoughtful about these links since we want them to work permanently.

To accomplish this, we may want to also address the changes I was proposing in #3174, which involved combining multiple variants for the same badge into a single popup.

@chris48s
Copy link
Member Author

chris48s commented Apr 17, 2022

Yeah we probably do need to think this through properly if we are going to do something that adds a lot of routes to the frontend given the frontend and service badges share a single URL namespace.
We've already got ourselves into a pickle with endpoint.

@chris48s
Copy link
Member Author

This is solved. Every badge documentation/builder page now has its own URL e.g: https://shields.io/badges/circle-ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend The Docusaurus app serving the docs site
Projects
None yet
Development

No branches or pull requests

2 participants