Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid parsing body twice in GithubAuthV4Service #3809

Open
chris48s opened this issue Jul 29, 2019 · 0 comments
Open

Avoid parsing body twice in GithubAuthV4Service #3809

chris48s opened this issue Jul 29, 2019 · 0 comments
Labels
core Server, BaseService, GitHub auth, Shared helpers

Comments

@chris48s
Copy link
Member

chris48s commented Jul 29, 2019 •
edited
Loading

📋 Description

At the moment we parse the response twice - once when we extract the rate limit from the response and then again when we extract the badge info. It would be handy to avoid this. See notes: #3763 (comment)
@chris48s chris48s added the core Server, BaseService, GitHub auth, Shared helpers label Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Server, BaseService, GitHub auth, Shared helpers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chris48s