Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub package.json badge croaks on dependencies with github links #2719

Closed
1 of 3 tasks
adiologydev opened this issue Jan 9, 2019 · 2 comments
Closed
1 of 3 tasks

GitHub package.json badge croaks on dependencies with github links #2719

adiologydev opened this issue Jan 9, 2019 · 2 comments
Assignees
@PyvesB
Labels
bug Bugs in badges and the frontend service-badge New or updated service badge

Comments

@adiologydev
Copy link

Are you experiencing an issue with...

🪲 Description
I'm getting Invalid Response Data while trying to use the badge for package.json version.

🔗 Link to the badge
https://img.shields.io/github/package-json/v/AdityaTD/PenguBot.svg?style=for-the-badge

💡 Possible Solution
Not really, I'm not sure why this is happening.
@paulmelnikow
Copy link
Member

paulmelnikow commented Jan 9, 2019 •
edited
Loading

Ah, this is a bug. Shields' schema validation for package.json is failing because of the github dependencies. Thanks for reporting!

Added: Let's get #2644 and #2709 merged so this can be worked on more easily.

@paulmelnikow paulmelnikow changed the title Version Badge failing to Load with "Invalid Response Data" GitHub package.json badge croaks on dependencies with github links Jan 9, 2019
@paulmelnikow paulmelnikow added bug Bugs in badges and the frontend service-badge New or updated service badge labels Jan 9, 2019
@PyvesB PyvesB self-assigned this Feb 17, 2019
@PyvesB PyvesB mentioned this issue Feb 18, 2019
Merged
@PyvesB
Copy link
Member

PyvesB commented Feb 19, 2019

Fixed in linked pull request, closing. 😉

@PyvesB PyvesB closed this as completed Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PyvesB PyvesB

Labels
bug Bugs in badges and the frontend service-badge New or updated service badge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@paulmelnikow @adiologydev @PyvesB