Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues with new frontend rewrite #1311

Closed
2 tasks
tooomm opened this issue Dec 2, 2017 · 6 comments
Closed
2 tasks

issues with new frontend rewrite #1311

tooomm opened this issue Dec 2, 2017 · 6 comments
Labels
frontend The Docusaurus app serving the docs site

Comments

@tooomm
Copy link
Contributor

tooomm commented Dec 2, 2017

Most likely introduced in #1273 (not live yet, but on staging):
untitled

  • Crazy big preview window with a lot of empty white space around
    --> Make the preview box smaller in size. Like 25-30% in width and 10-15% in height
  • If you put something in the link field, the copy-able boxes in the middle adjust. But one has no clue that something happened because it's hidden at the end of the code. For other boxes you might not even see all code from the beginning (used to be problematic with old version too)
    --> Make these fields bigger or allow them to be several lines like one code box
@paulmelnikow
Copy link
Member

  1. is probably an easy fix (though personally I would rather work on bigger changes to this screen like Add Username and Repo Name to Shield Creation fields #701).

  2. Seems an easy fix.

If anyone would like to tackle, feel free!

@paulmelnikow paulmelnikow added the frontend The Docusaurus app serving the docs site label Dec 2, 2017
@tooomm
Copy link
Contributor Author

tooomm commented Dec 2, 2017

Actually the badges involving GitHub have a Documentation paragraph further down:
untitled
So it would be needed to adjust the size dynamically regarding its content.

By the way:
Note how I have to use Chromium to make these preview windows show up at all - with other browsers they are broken for me as reported in #1305 (comment)

@paulmelnikow
Copy link
Member

Yea, we should definitely fix that. It's an issue in this function which I tried to implement on top of the new WHATWG URL API though it's proven to be more trouble than it's worth. Should replace it either with an established isomorphic library or our home-grown code from the old frontend.

@paulmelnikow
Copy link
Member

Popup should be fixed in #1322. Two issues mentioned in top post remain pending.

@RedSparr0w
Copy link
Member

in regards to the 2nd problem:
do you think it would be best to change the <input> to a <textarea> or <code> element?
Or maybe even something else?

I think <code> would be the best option as it could auto resize if it needed to wrap.

@paulmelnikow paulmelnikow mentioned this issue Dec 10, 2018
12 tasks
@paulmelnikow
Copy link
Member

Going to close this. #2496 should address a bunch of this. Feel free to open new targeted issues for whatever is still problematic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend The Docusaurus app serving the docs site
Projects
None yet
Development

No branches or pull requests

3 participants