Support options { leading, trailing } in throttle #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Readme update needed. |
|
I like the new leading option! It's only said to see the old throttle implementation go, it was so simple and nice |
|
debounce & debounceImmediate could be merged with the same configurations.. and maybe a third one: doubleEdged when both leading and trailing are true :) |
|
Yeah the new implementation looks more complicated. OTOH it will most likely perform better. The impl is very much borrowed from Kefir, which had the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similartly to Kefir.js,
throttlenow supports options { leading, trailing }. The default is trailing output, so that existing behaviour doesn't change.Implements #702