Using div.splitpanel against th-td on issues show bottom details view hook when rendering plugin related fileds - redmine 3 compatibility #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
view hook when rendering plugin related fileds - redmine 3 compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
There was a problem on the issue view. When rendering the backlogs plugin related fields on the bottom of the details section, the plugin used th and td elements, but the new redmine 3.3 style is div elements with splitpanel class. Because of that the fields didn't render properly.
I changed your view hook in that way that is uses the redmine's IssueHelper.issue_fields_rows method to render these fields so they are fit into the new layout.
Because of the new layout based on left and rigth columns and the old layout based on table row elements, it was necessary to reorder these fields a bit.