[DX] backdrop_process_states only works on lowest level of field in node form

[bradbulger]

In a node form array, the actual field array of type "#text" is located at something like "field_name[und][0][#value]". All the documentation of backdrop_process_states() describe it as working on the top level - ie setting $form['field_myfield]['#states']. That's how it works in Drupal 7 & 8.

I'm finding, though, that I have to go down to the text field - set $form['field_myfield']['und'][0]['value']['#states']. Setting at the initial field level has no or unexpected behavior. For instance, if the fields are inside a vertical tab fieldset, the whole fieldset gets set to "display:none;".

I am wondering if this is expected behavior? If it is, the documentation could be clearer about that. If not, then I suppose it's a bug.

This is in the Seven theme, if that's relevant. Backdrop 1.11.3.

[bradbulger]

Similar problems with date fields, except that there is no simple field type like #value for text fields. The only workaround that I have found is to create a new container in the same position in the form, move the date field inside it, and apply #states to the date field.

[bradbulger]

What's proving to be a simpler workaround is to set the language code array to a #type of "container" if it isn't set already, and apply #states at that level.

[oadaeh]

I can confirm this behavior.
However, for me I did not need [0]['#value']. It worked fine with only $form['field_myfield']['und']['#states']

[jenlampton]

This is weird, and I don't think intended. Adding milestone candidate label.

[stpaultim]

If I understand it correctly, this issue may be blocking the release of the Conditional Fields module.
backdrop-contrib/conditional_fields#2

[laryn]

Does the PR on this issue help here, too? (It solves the Conditional Fields functionality)
#5157

[bradbulger]

I'll try to test that.

[bradbulger]

OK, I was able to recreate the original problem, and then applied the PR from #5157 and that fixed it, in that it worked as documented. I was able to define $form['field_mytextfield']['#states'] and make visibility contingent on another field in the form.

[laryn]

Great! Are you able to glance over the code on that PR and give it a thumbs up if it makes sense to you? Then I think that PR would be mergable (I've already done a WFM on that PR).