Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Command - Check the download is successful before deleting the existing folder #297

Open
Tracked by #111
yorkshire-pudding opened this issue Jun 27, 2023 · 2 comments
Labels
feature-branch Relates to functionality in a feature branch not in 1.x-1.x type: enhancement

Comments

@yorkshire-pudding
Copy link
Collaborator

This is a subtask of #111 and relates to the issue-111-update-command branch.

At present the update command deletes the folder and then uses the download_bee_callback() function to re-download the module. If there is a connection issue to GitHub then this could break the site. There is a higher risk of a download failure if multiple projects are being downloaded in close succession.

We should use a temporary folder and check that it is valid before replacing the code.

@yorkshire-pudding yorkshire-pudding added type: enhancement feature-branch Relates to functionality in a feature branch not in 1.x-1.x labels Jun 27, 2023
@yorkshire-pudding yorkshire-pudding self-assigned this Jun 27, 2023
@hosef
Copy link

hosef commented Nov 22, 2023

@yorkshire-pudding I think that this is going to require a rewrite of the existing download command so that it supports using a temporary download folder and also downloading projects that already exists.

@yorkshire-pudding yorkshire-pudding removed their assignment Nov 23, 2023
@yorkshire-pudding
Copy link
Collaborator Author

@hosef - the first of those is already in place - it downloads to a temporary directory before copying to the destination and deleting the temporary directory. However, I think you are probably right that it makes sense to make the change in the download function. Despite assigning myself, I haven't had chance to look at this for months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-branch Relates to functionality in a feature branch not in 1.x-1.x type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants