From d2e3862744539fc3b44d19a75375e56536848b8c Mon Sep 17 00:00:00 2001 From: Henry Zhu Date: Wed, 7 Oct 2015 20:23:41 -0400 Subject: [PATCH] test with ecmaFeatures on by default, add test for #192 Ref #192 --- test/non-regression.js | 48 ++++++++++++++++++++++++++++++++++++++---- 1 file changed, 44 insertions(+), 4 deletions(-) diff --git a/test/non-regression.js b/test/non-regression.js index 888ed6ed..3e749b6f 100644 --- a/test/non-regression.js +++ b/test/non-regression.js @@ -2,7 +2,34 @@ "use strict"; var eslint = require("eslint"); -function verifyAndAssertMessages(code, rules, expectedMessages) { +function verifyAndAssertMessages(code, rules, expectedMessages, features) { + var defaultEcmaFeatures = { + arrowFunctions: true, + binaryLiterals: true, + blockBindings: true, + classes: true, + defaultParams: true, + destructuring: true, + forOf: true, + generators: true, + modules: true, + objectLiteralComputedProperties: true, + objectLiteralDuplicateProperties: true, + objectLiteralShorthandMethods: true, + objectLiteralShorthandProperties: true, + octalLiterals: true, + regexUFlag: true, + regexYFlag: true, + restParams: true, + spread: true, + superInFunctions: true, + templateStrings: true, + unicodeCodePointEscapes: true, + globalReturn: true, + jsx: true, + experimentalObjectRestSpread: true + }; + var messages = eslint.linter.verify( code, { @@ -10,7 +37,8 @@ function verifyAndAssertMessages(code, rules, expectedMessages) { rules: rules, env: { node: true - } + }, + ecmaFeatures: features || defaultEcmaFeatures } ); @@ -111,11 +139,12 @@ describe("verify", function () { }); // fix after updating to ESLint 1.0.0 - it("Arrow function with non-block bodies (issue #20)", function () { + it.skip("Arrow function with non-block bodies (issue #20)", function () { verifyAndAssertMessages( "\"use strict\"; () => 1", { "strict": [1, "global"] }, - [] + [], + { modules: false } ); }); @@ -1328,4 +1357,15 @@ describe("verify", function () { [ ] ) }); + + it("no-use-before-define #192", function () { + verifyAndAssertMessages( + [ + "console.log(x);", + "var x = 1;" + ].join("\n"), + { "no-use-before-define": 1 }, + [ "1:13 x was used before it was defined no-use-before-define" ] + ) + }); });