Repository navigation
Conversation
b7r6
force-pushed
the
fix/n3-placement-version
branch
3 times, most recently
from
October 7, 2026 20:34
fa9fe06 to
af4578c
Compare
Matching computed typed resource requirements once and parked that snapshot; assignment reloaded the current action but only guarded against double-assignment. It never compared the reloaded action's requirements against the ones the matcher used to pick the worker. So a matcher could park a 4 GiB snapshot of X; a peer runs X, hits a memory-limit kill, requeues X escalated to 8 GiB; the stale 4 GiB snapshot then dispatched X to a 4 GiB-only worker. The DB said 8 GiB but StartExecute and the reservation carried 4 GiB — the escalation was silently bypassed. Fix: assign_operation now carries the placement-relevant requirement snapshot the worker was chosen for. The accept, inside the same CAS that flips the action to Executing, rejects (Aborted) if the action's current platform_properties no longer match that snapshot. A stale proposal becomes a lost race; the action stays queued and is rematched against its current requirements. Dispatch still sends the parked payload, so rejecting before send keeps DB and worker in agreement. Regression test assignment_rejects_a_stale_placement_after_escalation reproduces the two-matcher interleaving: it FAILS without the guard (the 4 GiB placement is silently accepted to Executing) and PASSES with it. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
b7r6
force-pushed
the
fix/n3-placement-version
branch
from
October 8, 2026 16:32
af4578c to
21a424d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Lane A stability fix from the findings catalog (see
nativelink-findings-2026-10-05.csvon the
meta/findings-catalog-2026-10-05branch), rebased onto OSS main@bf4b3aa855. This fork PR exists to validate the change on CI that is
representative of upstream PR lanes (public read-only cache, same endpoints)
before any upstream submission.
How was this verified?
The branch carries its own regression tests (fails-without where the fix
class allows it — see the branch's test commits). This PR's purpose is the
full representative CI run; green here rehearses the exact checks an
upstream PR would face.
Risk
Fork-internal validation PR; nothing lands anywhere by merging this. The
underlying fix's risk assessment happens at upstream-submission time.
AI assistance
Agent-assisted pipeline (Claude) for rebase and PR mechanics under my
direction; the fix itself carries verification in its tests.