Update AssumptionOfMaryTest.php #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pioc92 Thanks for the additions, however since you've created separate PR's for the unit tests, both the unit test and source code still fail. Source code changes/additions and unit tests should be submitted together. Could you try correcting the PR's? Thanks! Sacha |
change fr_FR locale
|
i have corrected the Pr's, maybe it's ok now. Sorry because i'm not very familiar with PR and unit tests submissions |
|
@pioc92 No problem. A PR should ideally be a complete package/change, which should include unit tests as well. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.