Improve building: gh actions #444
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I'm fairly confident this works as expected as I am using it still. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take this PR as a base for further discussion.
This draft PR switches from circleci / hub.docker.com to gh actions / ghcr.io.
Due to caching, build times are reduced ~50% from ~10min uncached to ~5min cached.
Also when testing a lot of changes in a day (>20x), you won't be rate limited by maxmind anymore as the file gets cached.
Also, contributors don't need to create 3x accounts anymore (github, circleci, dockerhub) but only 1x which they usually have already (github account).
There are still some improvements to be made in the build.sh caching capabilities.
For the check to complete successfully, the repo needs access to a secret called MAX_TOKEN containing the max token ;)