Skip to content

Commit b5bb7e9

Browse files
authored
Fix catalyst test. (Kaggle#973)
* Fix catalyst test. Catalyst 21.x was released on 3/13. We were using 20.x. This release included a breaking change for the CheckpointCallback class which required updating our test. http://b/182904788 * Relax nnabla addition check
1 parent ba831d3 commit b5bb7e9

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

tests/test_catalyst.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -141,10 +141,10 @@ def test_mnist(self):
141141
logdir=logdir,
142142
num_epochs=num_epochs,
143143
verbose=False,
144-
callbacks=[CheckpointCallback(save_n_best=3)]
144+
callbacks=[CheckpointCallback(save_n_best=3, use_runner_logdir=True)]
145145
)
146146

147-
with open('./logs/checkpoints/_metrics.json') as f:
147+
with open('./logs/_metrics.json') as f:
148148
metrics = json.load(f)
149-
self.assertTrue(metrics['train.3']['loss'] < metrics['train.1']['loss'])
150-
self.assertTrue(metrics['best']['loss'] < 0.35)
149+
self.assertTrue(metrics['train.3']['valid']['loss'] < metrics['train.1']['valid']['loss'])
150+
self.assertTrue(metrics['best']['valid']['loss'] < 0.35)

tests/test_nnabla.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ def test_addition(self):
2020
# forward
2121
c.forward()
2222

23-
self.assertAlmostEqual(c.d, a.d + b.d)
23+
self.assertAlmostEqual(c.d, a.d + b.d, places=3)
2424

2525
@gpu_test
2626
def test_cuda_ext(self):

0 commit comments

Comments
 (0)