Skip to content

Conversation

@veewee
Copy link
Collaborator

@veewee veewee commented Oct 24, 2025

No description provided.

@azjezz
Copy link
Owner

azjezz commented Oct 24, 2025

we need to fix deprecations, and maybe bump revolt too

@veewee
Copy link
Collaborator Author

veewee commented Oct 24, 2025

Revolt seems to have an open PHP 85 support PR. Not sure how good it is but I dont know the package either.
I've put this one on draft and will pick it up further soon.

@veewee veewee force-pushed the php85 branch 3 times, most recently from eaca349 to 548012e Compare October 24, 2025 19:26
@coveralls
Copy link

coveralls commented Oct 24, 2025

Pull Request Test Coverage Report for Build 18800616230

Details

  • 17 of 17 (100.0%) changed or added relevant lines in 6 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.001%) to 98.445%

Files with Coverage Reduction New Missed Lines %
src/Psl/DateTime/Internal/high_resolution_time.php 2 87.5%
Totals Coverage Status
Change from base Build 18747030188: 0.001%
Covered Lines: 6269
Relevant Lines: 6368

💛 - Coveralls

@veewee veewee force-pushed the php85 branch 3 times, most recently from e2ec625 to f4a4ad7 Compare October 24, 2025 19:37
@veewee
Copy link
Collaborator Author

veewee commented Oct 24, 2025

This one should be good to go.
I've kept infection on PHP 8.4 since it breaks on the revolt deprecations.

The only deprecation warnings left are the once from revolt, which have been fixed in revoltphp/event-loop#110. Which hasn't been officially tagged yet.

@veewee veewee marked this pull request as ready for review October 24, 2025 19:44
@veewee veewee requested a review from azjezz October 24, 2025 19:44
@veewee veewee force-pushed the php85 branch 2 times, most recently from bf94239 to 74526fc Compare October 25, 2025 08:22
@azjezz azjezz merged commit 15153a6 into azjezz:next Oct 25, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants