[Class - Warrior] Sword Specialization doesn't proc with some melee abilities.

[Rorschach91]

Bug Triager Notes:

Original CC Reports:

1. [Warrior] Sunder Armor doesn't proc Sudden Death, Sword Specialization chromiecraft/chromiecraft#7398 (comment)
2. [Warrior] Hamstring doesn't proc Sudden Death, Sword Specialization chromiecraft/chromiecraft#7399 (comment)
3. [Warrior] Rend doesn't proc Sword Specialization chromiecraft/chromiecraft#7400 (comment)

It seems that Sword Specialization talent doesn't proc if players use these melee abilities: Hamstring, Sunder Armor and Rend.

What client do you play on?

enGB

Faction

Alliance

Content Phase:

Generic

Current Behaviour

Sunder Armor doesn't proc Sudden Death, Sword Specialization

Expected Blizzlike Behaviour

It should

Source

Don't have direct sources, but it is implied by existing implementation and spell description:

• Sunder Armor already procs Mongoose
• Rend procs Sudden Death, Mongoose
• both Rend and Sunder Armor have the same Spell flags:
  
• both Sudden Death and Sword Spec have the same description of hitting a target with a weapon, while Rend says "Requires melee weapon"

Steps to reproduce the problem

0. .mod hp 2000000

1. Spam macro till full rage
   /target Asdx
   .cooldown
   /targetlasttarget
   /cast Bloodrage

2. Go to target dummy and spam till out of rage
   /stopattack
   /cast Sunder Armor
   /stopattack

3. Go to Step 1

4. Check log/damage meter(some white hits will slip, but you can see on logs it wasnt a Sword Spec proc)

Extra Notes

No response

AC rev. hash/commit

chromiecraft@529e914

Operating system

Ubuntu 22.04

Modules

• mod-ah-bot
• mod-bg-item-reward
• mod-BreakingNewsOverride
• mod-cfbg
• mod-chat-transmitter
• mod-cta-switch
• mod-desertion-warnings
• mod-duel-reset
• mod-eluna
• mod-instanced-worldbosses
• mod-ip-tracker
• mod-low-level-arena
• mod-low-level-rbg
• mod-multi-client-check
• mod-progression-system
• mod-pvp-titles
• mod-pvpstats-announcer
• mod-queue-list-cache
• mod-rdf-expansion
• mod-transmog
• mod-weekend-xp
• mod-zone-difficulty
• lua-carbon-copy
• lua-event-scripts
• lua-exchange-npc
• lua-level-up-reward
• lua-recruit-a-friend
• lua-send-and-bind
• lua-temp-announcements
• lua-zonecheck

Customizations

None

Server

ChromieCraft