Skip to content

Commit 4e19b94

Browse files
authored
feat: improve checking if a member is private in sort-classes rule
1 parent 4f3da85 commit 4e19b94

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

rules/sort-classes.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,8 @@ export default createEslintRule<Options, MESSAGE_ID>({
352352
}
353353
}
354354

355-
let isPrivateName = name.startsWith('#')
355+
let isPrivateHash =
356+
'key' in member && member.key.type === 'PrivateIdentifier'
356357
let decorated =
357358
'decorators' in member && member.decorators.length > 0
358359

@@ -384,7 +385,7 @@ export default createEslintRule<Options, MESSAGE_ID>({
384385

385386
if (member.accessibility === 'protected') {
386387
modifiers.push('protected')
387-
} else if (member.accessibility === 'private' || isPrivateName) {
388+
} else if (member.accessibility === 'private' || isPrivateHash) {
388389
modifiers.push('private')
389390
} else {
390391
modifiers.push('public')
@@ -436,7 +437,7 @@ export default createEslintRule<Options, MESSAGE_ID>({
436437

437438
if (member.accessibility === 'protected') {
438439
modifiers.push('protected')
439-
} else if (member.accessibility === 'private' || isPrivateName) {
440+
} else if (member.accessibility === 'private' || isPrivateHash) {
440441
modifiers.push('private')
441442
} else {
442443
modifiers.push('public')
@@ -473,7 +474,7 @@ export default createEslintRule<Options, MESSAGE_ID>({
473474

474475
if (member.accessibility === 'protected') {
475476
modifiers.push('protected')
476-
} else if (member.accessibility === 'private' || isPrivateName) {
477+
} else if (member.accessibility === 'private' || isPrivateHash) {
477478
modifiers.push('private')
478479
} else {
479480
modifiers.push('public')

0 commit comments

Comments
 (0)