perf: remove node cloning to improve performance

azat-io · azat-io · commit 00b2cc3c04ff · 2024-08-05T18:45:27.000+03:00
diff --git a/rules/sort-array-includes.ts b/rules/sort-array-includes.ts
@@ -115,8 +115,8 @@ export default createEslintRule<Options, MESSAGE_ID>({
                         ? `${element.value}`
                         : sourceCode.text.slice(...element.range),
                     size: rangeToDiff(element.range),
-                    node: structuredClone(element),
                     type: element.type,
+                    node: element,
                     group,
                   })
                 }
diff --git a/rules/sort-astro-attributes.ts b/rules/sort-astro-attributes.ts
@@ -169,8 +169,8 @@ export default createEslintRule<Options<string[]>, MESSAGE_ID>({
               }
 
               accumulator.at(-1)!.push({
-                node: structuredClone(attribute) as TSESTree.Node,
                 size: rangeToDiff(attribute.range),
+                node: attribute as TSESTree.Node,
                 group: getGroup(),
                 name,
               })
diff --git a/rules/sort-classes.ts b/rules/sort-classes.ts
@@ -387,8 +387,8 @@ export default createEslintRule<Options, MESSAGE_ID>({
 
             let value = {
               size: rangeToDiff(member.range),
-              node: structuredClone(member),
               group: getGroup(),
+              node: member,
               dependencies,
               name,
             }
diff --git a/rules/sort-enums.ts b/rules/sort-enums.ts
@@ -127,7 +127,7 @@ export default createEslintRule<Options, MESSAGE_ID>({
 
             let sortingNode = {
               size: rangeToDiff(member.range),
-              node: structuredClone(member),
+              node: member,
               name,
             }
             accumulator.at(-1)!.push(sortingNode)
diff --git a/rules/sort-exports.ts b/rules/sort-exports.ts
@@ -81,8 +81,8 @@ export default createEslintRule<Options, MESSAGE_ID>({
     ) => {
       parts.at(-1)!.push({
         size: rangeToDiff(node.range),
-        node: structuredClone(node),
         name: node.source.value,
+        node,
       })
     }
 
diff --git a/rules/sort-imports.ts b/rules/sort-imports.ts
@@ -437,8 +437,8 @@ export default createEslintRule<Options<string[]>, MESSAGE_ID>({
 
       nodes.push({
         size: rangeToDiff(node.range),
-        node: structuredClone(node),
         group: computeGroup(node),
+        node,
         name,
         ...(options.type === 'line-length' &&
           options.maxLineLength && {
diff --git a/rules/sort-interfaces.ts b/rules/sort-interfaces.ts
@@ -198,7 +198,7 @@ export default createEslintRule<Options<string[]>, MESSAGE_ID>({
 
               let elementSortingNode = {
                 size: rangeToDiff(element.range),
-                node: structuredClone(element),
+                node: element,
                 name,
               }
 
diff --git a/rules/sort-intersection-types.ts b/rules/sort-intersection-types.ts
@@ -177,8 +177,8 @@ export default createEslintRule<Options, MESSAGE_ID>({
         return {
           name: sourceCode.text.slice(...type.range),
           size: rangeToDiff(type.range),
-          node: structuredClone(type),
           group: getGroup(),
+          node: type,
         }
       })
 
diff --git a/rules/sort-jsx-props.ts b/rules/sort-jsx-props.ts
@@ -178,8 +178,8 @@ export default createEslintRule<Options<string[]>, MESSAGE_ID>({
 
               let jsxNode = {
                 size: rangeToDiff(attribute.range),
-                node: structuredClone(attribute),
                 group: getGroup(),
+                node: attribute,
                 name,
               }
 
diff --git a/rules/sort-maps.ts b/rules/sort-maps.ts
@@ -121,7 +121,7 @@ export default createEslintRule<Options, MESSAGE_ID>({
 
               return {
                 size: rangeToDiff(element.range),
-                node: structuredClone(element),
+                node: element,
                 name,
               }
             })
diff --git a/rules/sort-named-exports.ts b/rules/sort-named-exports.ts
@@ -93,8 +93,8 @@ export default createEslintRule<Options, MESSAGE_ID>({
           }
           return {
             size: rangeToDiff(specifier.range),
-            node: structuredClone(specifier),
             name: specifier.local.name,
+            node: specifier,
             group,
           }
         })
diff --git a/rules/sort-named-imports.ts b/rules/sort-named-imports.ts
@@ -114,7 +114,7 @@ export default createEslintRule<Options, MESSAGE_ID>({
 
           return {
             size: rangeToDiff(specifier.range),
-            node: structuredClone(specifier),
+            node: specifier,
             group,
             name,
           }
diff --git a/rules/sort-object-types.ts b/rules/sort-object-types.ts
@@ -191,7 +191,7 @@ export default createEslintRule<Options<string[]>, MESSAGE_ID>({
 
               let memberSortingNode = {
                 size: rangeToDiff(member.range) - endSize,
-                node: structuredClone(member),
+                node: member,
                 name,
               }
 
diff --git a/rules/sort-objects.ts b/rules/sort-objects.ts
@@ -298,7 +298,7 @@ export default createEslintRule<Options, MESSAGE_ID>({
 
               let propSortingNode = {
                 size: rangeToDiff(prop.range),
-                node: structuredClone(prop),
+                node: prop,
                 name,
               }
 
diff --git a/rules/sort-svelte-attributes.ts b/rules/sort-svelte-attributes.ts
@@ -176,7 +176,7 @@ export default createEslintRule<Options<string[]>, MESSAGE_ID>({
               }
 
               accumulator.at(-1)!.push({
-                node: structuredClone(attribute) as unknown as TSESTree.Node,
+                node: attribute as unknown as TSESTree.Node,
                 size: rangeToDiff(attribute.range),
                 group: getGroup(),
                 name,
diff --git a/rules/sort-switch-case.ts b/rules/sort-switch-case.ts
@@ -104,7 +104,7 @@ export default createEslintRule<Options, MESSAGE_ID>({
 
             return {
               size: rangeToDiff(caseNode.test?.range ?? caseNode.range),
-              node: structuredClone(caseNode),
+              node: caseNode,
               name,
             }
           },
@@ -160,7 +160,7 @@ export default createEslintRule<Options, MESSAGE_ID>({
               node: right.node,
               fix: fixer => {
                 let additionalFixes: TSESLint.RuleFix[] = []
-                let nodeGroups = structuredClone(nodes).reduce<
+                let nodeGroups = nodes.reduce<
                   SortingNode<TSESTree.SwitchCase>[][]
                 >(
                   (
diff --git a/rules/sort-union-types.ts b/rules/sort-union-types.ts
@@ -177,8 +177,8 @@ export default createEslintRule<Options, MESSAGE_ID>({
         return {
           name: sourceCode.text.slice(...type.range),
           size: rangeToDiff(type.range),
-          node: structuredClone(type),
           group: getGroup(),
+          node: type,
         }
       })
 
diff --git a/rules/sort-variable-declarations.ts b/rules/sort-variable-declarations.ts
@@ -140,7 +140,7 @@ export default createEslintRule<Options, MESSAGE_ID>({
 
           return {
             size: rangeToDiff(declaration.range),
-            node: structuredClone(declaration),
+            node: declaration,
             dependencies,
             name,
           }
diff --git a/rules/sort-vue-attributes.ts b/rules/sort-vue-attributes.ts
@@ -179,7 +179,7 @@ export default createEslintRule<Options<string[]>, MESSAGE_ID>({
               }
 
               accumulator.at(-1)!.push({
-                node: structuredClone(attribute) as unknown as TSESTree.Node,
+                node: attribute as unknown as TSESTree.Node,
                 size: rangeToDiff(attribute.range),
                 group: getGroup(),
                 name,

Original file line number	Diff line number	Diff line change
`@@ -169,8 +169,8 @@ export default createEslintRule<Options<string[]>, MESSAGE_ID>({`
`169`	`169`	`}`
`170`	`170`
`171`	`171`	`accumulator.at(-1)!.push({`
`172`		`- node: structuredClone(attribute) as TSESTree.Node,`
`173`	`172`	`size: rangeToDiff(attribute.range),`
	`173`	`+ node: attribute as TSESTree.Node,`
`174`	`174`	`group: getGroup(),`
`175`	`175`	`name,`
`176`	`176`	`})`
Original file line number	Diff line number	Diff line change
`@@ -387,8 +387,8 @@ export default createEslintRule<Options, MESSAGE_ID>({`
`387`	`387`
`388`	`388`	`let value = {`
`389`	`389`	`size: rangeToDiff(member.range),`
`390`		`- node: structuredClone(member),`
`391`	`390`	`group: getGroup(),`
	`391`	`+ node: member,`
`392`	`392`	`dependencies,`
`393`	`393`	`name,`
`394`	`394`	`}`
Original file line number	Diff line number	Diff line change
`@@ -127,7 +127,7 @@ export default createEslintRule<Options, MESSAGE_ID>({`
`127`	`127`
`128`	`128`	`let sortingNode = {`
`129`	`129`	`size: rangeToDiff(member.range),`
`130`		`- node: structuredClone(member),`
	`130`	`+ node: member,`
`131`	`131`	`name,`
`132`	`132`	`}`
`133`	`133`	`accumulator.at(-1)!.push(sortingNode)`
Original file line number	Diff line number	Diff line change
`@@ -81,8 +81,8 @@ export default createEslintRule<Options, MESSAGE_ID>({`
`81`	`81`	`) => {`
`82`	`82`	`parts.at(-1)!.push({`
`83`	`83`	`size: rangeToDiff(node.range),`
`84`		`- node: structuredClone(node),`
`85`	`84`	`name: node.source.value,`
	`85`	`+ node,`
`86`	`86`	`})`
`87`	`87`	`}`
`88`	`88`
Original file line number	Diff line number	Diff line change
`@@ -198,7 +198,7 @@ export default createEslintRule<Options<string[]>, MESSAGE_ID>({`
`198`	`198`
`199`	`199`	`let elementSortingNode = {`
`200`	`200`	`size: rangeToDiff(element.range),`
`201`		`- node: structuredClone(element),`
	`201`	`+ node: element,`
`202`	`202`	`name,`
`203`	`203`	`}`
`204`	`204`
Original file line number	Diff line number	Diff line change
`@@ -177,8 +177,8 @@ export default createEslintRule<Options, MESSAGE_ID>({`
`177`	`177`	`return {`
`178`	`178`	`name: sourceCode.text.slice(...type.range),`
`179`	`179`	`size: rangeToDiff(type.range),`
`180`		`- node: structuredClone(type),`
`181`	`180`	`group: getGroup(),`
	`181`	`+ node: type,`
`182`	`182`	`}`
`183`	`183`	`})`
`184`	`184`
Original file line number	Diff line number	Diff line change
`@@ -178,8 +178,8 @@ export default createEslintRule<Options<string[]>, MESSAGE_ID>({`
`178`	`178`
`179`	`179`	`let jsxNode = {`
`180`	`180`	`size: rangeToDiff(attribute.range),`
`181`		`- node: structuredClone(attribute),`
`182`	`181`	`group: getGroup(),`
	`182`	`+ node: attribute,`
`183`	`183`	`name,`
`184`	`184`	`}`
`185`	`185`
Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,7 @@ export default createEslintRule<Options, MESSAGE_ID>({`
`121`	`121`
`122`	`122`	`return {`
`123`	`123`	`size: rangeToDiff(element.range),`
`124`		`- node: structuredClone(element),`
	`124`	`+ node: element,`
`125`	`125`	`name,`
`126`	`126`	`}`
`127`	`127`	`})`