Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a security login #43

Open
ludoo0d0a opened this issue Oct 24, 2016 · 1 comment
Open

Add a security login #43

ludoo0d0a opened this issue Oct 24, 2016 · 1 comment

Comments

@ludoo0d0a
Copy link

please intoduce a mininum of security.
at least, a basic authentication box can be enough (https://github.com/expressjs/basic-auth-connect).

Letting this app public is not safe.

thanks

@azat-co
Copy link
Owner

azat-co commented Jun 17, 2017

@ludoo0d0a yes. sure! security is important... that's why just a basic auth might not be enough. the idea is that people will be forced to implement their own security on top of the app if we don't provide it... but what integration would you like to see? having a password will require a database for the app... which increases the complexity, hardcoding is another option. GitHub OAuth will require getting GitHub keys, etc.
so it's not a simple path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants