refactor: make kotlin improvements where possible (firebase#1005)

Author: thatfiredev

auth/app/src/main/java/com/google/firebase/quickstart/auth/kotlin/AnonymousAuthActivity.kt

@@ -159,8 +159,7 @@ class AnonymousAuthActivity : BaseActivity(), View.OnClickListener {
     }
 
     override fun onClick(v: View) {
-        val i = v.id
-        when (i) {
+        when (v.id) {
             R.id.buttonAnonymousSignIn -> signInAnonymously()
             R.id.buttonAnonymousSignOut -> signOut()
             R.id.buttonLinkAccount -> linkAccount()

auth/app/src/main/java/com/google/firebase/quickstart/auth/kotlin/GoogleSignInActivity.kt

@@ -163,8 +163,7 @@ class GoogleSignInActivity : BaseActivity(), View.OnClickListener {
     }
 
     override fun onClick(v: View) {
-        val i = v.id
-        when (i) {
+        when (v.id) {
             R.id.signInButton -> signIn()
             R.id.signOutButton -> signOut()
             R.id.disconnectButton -> revokeAccess()

config/app/src/main/java/com/google/samples/quickstart/config/kotlin/MainActivity.kt

@@ -56,7 +56,7 @@ class MainActivity : AppCompatActivity() {
         remoteConfig.fetchAndActivate()
                 .addOnCompleteListener(this) { task ->
                     if (task.isSuccessful) {
-                        val updated = task.getResult()
+                        val updated = task.result
                         Log.d(TAG, "Config params updated: $updated")
                         Toast.makeText(this, "Fetch and activate succeeded",
                                 Toast.LENGTH_SHORT).show()

functions/app/src/main/java/com/google/samples/quickstart/functions/kotlin/MainActivity.kt

@@ -111,7 +111,7 @@ class MainActivity : AppCompatActivity(), View.OnClickListener {
 
         // [START call_add_numbers]
         addNumbers(firstNumber, secondNumber)
-                .addOnCompleteListener(OnCompleteListener { task ->
+                .addOnCompleteListener { task ->
                     if (!task.isSuccessful) {
                         val e = task.exception
                         if (e is FirebaseFunctionsException) {
@@ -128,15 +128,15 @@ class MainActivity : AppCompatActivity(), View.OnClickListener {
                         // [START_EXCLUDE]
                         Log.w(TAG, "addNumbers:onFailure", e)
                         showSnackbar("An error occurred.")
-                        return@OnCompleteListener
+                        return@addOnCompleteListener
                         // [END_EXCLUDE]
                     }
 
                     // [START_EXCLUDE]
                     val result = task.result
                     fieldAddResult.setText(result.toString())
                     // [END_EXCLUDE]
-                })
+                }
         // [END call_add_numbers]
     }
 

inappmessaging/app/src/main/java/com/google/firebase/fiamquickstart/kotlin/KotlinMainActivity.kt

@@ -36,13 +36,11 @@ class KotlinMainActivity : AppCompatActivity() {
 
         // Get and display/log the Instance ID
         FirebaseInstanceId.getInstance().instanceId
-                .addOnSuccessListener(object : OnSuccessListener<InstanceIdResult> {
-                    override fun onSuccess(instanceIdResult: InstanceIdResult) {
-                        val instanceId = instanceIdResult.id
-                        instanceIdText.text = getString(R.string.instance_id_fmt, instanceId)
-                        Log.d(TAG, "InstanceId: $instanceId")
-                    }
-                })
+                .addOnSuccessListener { instanceIdResult ->
+                    val instanceId = instanceIdResult.id
+                    instanceIdText.text = getString(R.string.instance_id_fmt, instanceId)
+                    Log.d(TAG, "InstanceId: $instanceId")
+                }
     }
 
     companion object {

mlkit-smartreply/app/src/main/java/com/google/firebase/samples/apps/mlkit/smartreply/kotlin/chat/ChatViewModel.kt

@@ -54,7 +54,7 @@ class ChatViewModel : ViewModel() {
     }
 
     internal fun addMessage(message: String) {
-        var list: MutableList<Message>? = messageList.getValue()
+        var list: MutableList<Message>? = messageList.value
         if (list == null) {
             list = ArrayList()
         }