Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷🏼 Upgrade golangci-lint to the latest version #775

Closed
ccamel opened this issue Oct 7, 2024 · 3 comments · Fixed by #776
Closed

👷🏼 Upgrade golangci-lint to the latest version #775

ccamel opened this issue Oct 7, 2024 · 3 comments · Fixed by #776
Assignees
Labels
good first issue Good for newcomers

Comments

@ccamel
Copy link
Member

ccamel commented Oct 7, 2024

Purpose

The current version of golangci-lint used in this repo is quite old (v1.56). It would be beneficial to update to the latest available version to take advantage of the latest improvements, bug fixes, and features.

Suggested action:

  • Update golangci-lint to the latest stable version.
  • Update the codebase if the linter requires any changes.
@ccamel ccamel added the good first issue Good for newcomers label Oct 7, 2024
@dangogh
Copy link
Contributor

dangogh commented Oct 7, 2024

working on this

@dangogh
Copy link
Contributor

dangogh commented Oct 7, 2024

question: a number of gosec:G115 warnings (potential int conversion overflow). Should be able to safely ignore (many of) these, but opinion on how this project wants to handle them?

@ccamel
Copy link
Member Author

ccamel commented Oct 8, 2024

@dangogh That’s a great question. I agree that not all G115 warnings can be properly addressed (for now), and it makes sense to disable them on a case-by-case basis. From what I can see, you’ve already handled this appropriately in the commit f903d5f, so this approach looks good to me. 👍

@ccamel ccamel closed this as completed Oct 8, 2024
@ccamel ccamel linked a pull request Oct 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants