Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪 Simplify error message formatting in test cases #771

Open
coderabbitai bot opened this issue Oct 5, 2024 · 0 comments · May be fixed by #795
Open

🧪 Simplify error message formatting in test cases #771

coderabbitai bot opened this issue Oct 5, 2024 · 0 comments · May be fixed by #795
Assignees
Labels
good first issue Good for newcomers

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 5, 2024

As discussed in PR #769 comment, the error messages in test cases can be simplified by removing the unnecessary transformation using strings.Join(strings.Split(...)). This was initially implemented because error messages used to be atoms but are now strings (lists of characters), and the change was made to update the tests without too much hassle.

Refactoring the error messages to use direct string literals will improve readability and maintainability.

Requested by @ccamel.

@ccamel ccamel changed the title Simplify error message formatting in test cases 🧪 Simplify error message formatting in test cases Oct 5, 2024
@ccamel ccamel added the good first issue Good for newcomers label Oct 7, 2024
@panmini panmini linked a pull request Oct 28, 2024 that will close this issue
@ccamel ccamel linked a pull request Oct 31, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: 📆 To do
Development

Successfully merging a pull request may close this issue.

1 participant