Update supported models for Liger Kernel #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmm1
reviewed
Aug 27, 2024
| @@ -24,6 +24,8 @@ | |||
| from liger_kernel.transformers.geglu import LigerGEGLUMLP | |||
| from liger_kernel.transformers.model.llama import lce_forward | |||
| from liger_kernel.transformers.model.qwen2 import lce_forward as qwen2_lce_forward | |||
| from liger_kernel.transformers.model.mistral import lce_forward as mistral_lce_forward | |||
| from liger_kernel.transformers.model.gemma import lce_forward as gemma_lce_forward | |||
There was a problem hiding this comment.
please move these down into the various elif clauses below
otherwise the plugin will fail to load on older versions of the liger-kernel dependency, even if the user isn't necessarily dealing with mistral or gemma models themselves
cc #1876
There was a problem hiding this comment.
I went ahead and moved these.
winglian
force-pushed
the
liger_updates
branch
from
b8f787d
to
89e0c2c
Compare
winglian
approved these changes
Aug 28, 2024
Add Mistral LCE, Gemma LCE, Gemma 2 without LCE (softcapping is not yet implemented for Gemma in Liger Kernel LCE forward), Phi3 without LCE
winglian
force-pushed
the
liger_updates
branch
from
5bc5d51
to
78cdbc6
Compare
|
Updated liger to 0.2.1 in main, so rebased to make sure everything is kosher. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrates the following updates from the main branch of Liger Kernel:
Mistral LCE (linkedin/Liger-Kernel#93)
Gemma LCE (linkedin/Liger-Kernel#111)
Gemma 2 without LCE (softcapping is not yet implemented for Gemma in Liger Kernel LCE forward at the moment, see: linkedin/Liger-Kernel#121 (comment))
Phi3 LCE (linkedin/Liger-Kernel#76) (linkedin/Liger-Kernel#103)
Motivation and Context
How has this been tested?
Screenshots (if appropriate)
Types of changes
Social Handles (Optional)