Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build + publish docker image #365

Open
ashleygwilliams opened this issue Aug 25, 2023 · 1 comment
Open

build + publish docker image #365

ashleygwilliams opened this issue Aug 25, 2023 · 1 comment

Comments

@ashleygwilliams
Copy link
Member

e.g. https://github.com/libsql/sqld/blob/main/.github/workflows/publish.yml#L27

@Gankra Gankra added the feature request New feature or request label Aug 29, 2023
@Gankra Gankra added this to the 0.4.0 milestone Sep 21, 2023
@Gankra Gankra self-assigned this Sep 27, 2023
@Gankra Gankra modified the milestones: 0.4.0, november 2023 Oct 26, 2023
@Gankra Gankra removed this from the november 2023 milestone Sep 30, 2024
@Gankra
Copy link
Contributor

Gankra commented Sep 30, 2024

Historical context: this was describing a feature that would build a docker image containing your binaries, such that someone could "run your app" by just fetching and running the docker image.

One of the annoyances we ran into is that docker really likes to make "build + publish" a single operation, whereas we would prefer to build the docker image in an earlier step in parallel with everything else, and then only publish it afterwards, on a potentially different machine.

While docker has some facilities for exporting/importing an image in a way that isn't Publishing It, it requires some special modes to be enabled that are incompatible with other useful features like multi-arch docker images. Docker is a frustrating mess.

At least one user has opted to do custom docker build + publish stuff in their build step as a result, which is understandable given the issues.

@Gankra Gankra removed their assignment Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants