Skip to content

Conversation

@halx99
Copy link
Collaborator

@halx99 halx99 commented Sep 17, 2025

Describe your changes

  • Mobile platforms: when recive screen size changed, re-layout RenderView first, then invoke applicationScreenSizeChanged
    • Android
    • iOS
  • Desktop platforms: add missing applicationScreenSizeChanged calls

Issue ticket number and link

Additional issue

This PR will also fix #2763, and FAQ in wiki: https://github.com/axmolengine/axmol/wiki/FAQ#q-in-my-landscape-app-for-android-after-coming-back-from-the-background-to-the-foreground-sometimes-the-image-is-shifted-to-the-top-left-is-there-something-i-can-do-to-avoid-it

Checklist before requesting a review

For each PR

  • Add Copyright if it missed:
    - "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

  • I have performed a self-review of my code.

    Optional:

    • I have checked readme and add important infos to this PR.
    • I have added/adapted some tests too.

For core/new feature PR

  • I have checked readme and add important infos to this PR.
  • I have added thorough tests.

Axmol 3.x ------------------------------------------------------------

For each 3.x PR

  • Check the '#include "axmol.h"' and replace it with the needed headers.

@halx99 halx99 added this to the 3.0.0 milestone Sep 17, 2025
@halx99 halx99 linked an issue Sep 17, 2025 that may be closed by this pull request
@halx99 halx99 changed the title Handling orientation change Handling screen orientation change for all platforms Sep 17, 2025
@halx99
Copy link
Collaborator Author

halx99 commented Sep 17, 2025

/clang-format

@halx99 halx99 marked this pull request as ready for review September 17, 2025 11:53
@halx99 halx99 added the enhancement New feature or request label Sep 17, 2025
@axmol-bot
Copy link
Collaborator

👋 @halx99 Command /clang-format received. Running code formatting, please wait...

@axmol-bot
Copy link
Collaborator

✅ Formatting completed and changes have been committed to the PR branch: handle-orientation-change.
@halx99 please refresh to see the latest code.

@halx99
Copy link
Collaborator Author

halx99 commented Sep 17, 2025

/clang-format

@axmol-bot
Copy link
Collaborator

👋 @halx99 Command /clang-format received. Running code formatting, please wait...

@axmol-bot
Copy link
Collaborator

✅ Formatting completed and changes have been committed to the PR branch: handle-orientation-change.
@halx99 please refresh to see the latest code.

@halx99 halx99 merged commit 58c07d8 into dev Sep 18, 2025
19 checks passed
@halx99 halx99 deleted the handle-orientation-change branch September 18, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

3 participants