Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] S3 Compatibility #59

Open
sanskar-mk2 opened this issue Mar 5, 2024 · 6 comments
Open

[Feature Request] S3 Compatibility #59

sanskar-mk2 opened this issue Mar 5, 2024 · 6 comments
Assignees

Comments

@sanskar-mk2
Copy link
Contributor

Many cloud filesystem are s3 compatible, if we can do it, then we can have more ways to store file. I am working on it. Do you have suggestions?

@axeloz
Copy link
Owner

axeloz commented Mar 5, 2024

Hi @sanskar-mk2, you want to add the S3 support for Filesharing? Is that right?

@sanskar-mk2
Copy link
Contributor Author

Yes, I have a working S3 compatible (I am using Digital Ocean Spaces) version of the app. Are you working on any such plans right now? If not, I will be happy to PR it.

Additionally I have also made some quality of life updates to it.

@axeloz
Copy link
Owner

axeloz commented Mar 5, 2024

No, I had no plan on implementing S3 but with Flysystem on Laravel, it's pretty straightforward. Question is: is there a need for this?

@sanskar-mk2
Copy link
Contributor Author

Yes, there is need for it, since the filesystem is hardcoded in the controllers. And to create a zip file, you cannot write directly to S3. Some little changes are needed.

@axeloz
Copy link
Owner

axeloz commented Mar 5, 2024

I was talking about the functional need, a user request. But if you think some users may need to change the disk driver, then you are right: some improvements are required.

@axeloz axeloz self-assigned this Mar 5, 2024
@sanskar-mk2
Copy link
Contributor Author

Yes, people use different disk driver. I need it so I can buy compute and storage separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants