-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test io_uring_prep_sendto
#1089
Comments
Even though adding such a test would be welcome, but I don't think it's strictly required. It's a simple wrapper, and passing an address is exercised at least in send-zerocopy.c for normal and as well zerocopy modes. https://github.com/axboe/liburing/blob/master/test/send-zerocopy.c#L375 |
Just a basic test should do, nothing fancy, to make sure all the functions are covered with test. I know its not very important but you never know when things will be effected, even a simple type change or new attribute added could effect each other. |
It's already being implicitly tested. I have a feeling you're asking for this to duplicate it in your framework? If so, please just go ahead and write it and send a PR. We're getting inundated with "please add this or that" these days, and it's not scaleable. If some tests or documentation is missing, please feel free to write them and submit them. |
It took me a while to find all those, don't you use something like coverage in C? It normally tells you functions that are not covered in test, figured it would be good to let you guys know. I would have added all those into 1 issue, but I think you mentioned somewhere to create each post per issue.
No, I don't rewrite the test since it wouldn't make much sense to redo what you have already done. I was trying to do that with |
Need to create basic test for
io_uring_prep_sendto
The text was updated successfully, but these errors were encountered: