Skip to content

Conversation

@chrylis
Copy link

@chrylis chrylis commented Dec 9, 2022

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Export the async-enabled subclass of the Amazon SNS client. Since this is built by a factory, this change is entirely declarative.

💡 Motivation and Context

fixes #564

💚 How did you test it?

The automated tests were not working because of a Checkstyle error in Core.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated reference documentation to reflect the change
  • All tests passing
  • No breaking changes

🔮 Next steps

@maciejwalkowiak
Copy link
Contributor

Ideally this change should be non-breaking - meaning async client should be exposed as a bean in addition to already existing sync client.

@chrylis
Copy link
Author

chrylis commented Dec 12, 2022

Ideally this change should be non-breaking - meaning async client should be exposed as a bean in addition to already existing sync client.

The change is non-breaking as far as I can tell, but I wasn't sure whether the checklist was something I was supposed to do myself or was a code-review step.

@maciejwalkowiak
Copy link
Contributor

The change is non-breaking as far as I can tell

My bad. Async one extends the Sync one.

@maciejwalkowiak maciejwalkowiak merged commit 1b82edb into awspring:2.4.x Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants