Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] xattrs cannot be disabled on layers with volume mounts #1314

Open
sondavidb opened this issue Jul 17, 2024 · 0 comments
Open

[Bug] xattrs cannot be disabled on layers with volume mounts #1314

sondavidb opened this issue Jul 17, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@sondavidb
Copy link
Contributor

Description

There's a bug in containerd/continuity#244 where CopyDir() fails on filesystems without xattrs. The syscall to list xattrs will fail with ENOTSUP, and continuity will treat it as a regular error and say it failed. When creating a container, if there are volumes to mount, nerdctl will make a call to this CopyDir() function. This is a problem for us, since by default we disable xattrs unless whiteout directories or file xattrs are detected.

For now we can have xattrs be on by default and allow this change to be opted into, but we should either wait for the upstream bug fix (which could take a long time) or find a somewhat elegant workaround in SOCI.

Steps to reproduce the bug

  1. Pull image with a layer that has a volume mount without whiteout dirs or xattrs. (ARM64 for rabbitmq@sha256:19e69a7a65fa6b1d0a5c658bad8ec03d2c9900a98ebbc744c34d49179ff517bf worked for this.)
  2. Create SOCI index with xattrs optimization enabled.
  3. Push to registry
  4. Pull from registry with SOCI and attempt to run container

Describe the results you expected

Container should run instead of erroring with "operation not supported"

Host information

  1. OS: Linux
  2. Snapshotter Version: v0.6.1
  3. Containerd Version: v1.7.18

Any additional context or information about the bug

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant