From 44533f4254c79bae2c2037c21a7a49fc59d77933 Mon Sep 17 00:00:00 2001 From: Vlad Volodkin Date: Tue, 20 Aug 2024 12:22:23 +0000 Subject: [PATCH] Use separate bucket for bench results, run on PRs Signed-off-by: Vlad Volodkin --- .github/workflows/bench.yml | 6 +++--- .github/workflows/bench_pr.yml | 4 ++++ .github/workflows/bench_s3express.yml | 4 ++-- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/.github/workflows/bench.yml b/.github/workflows/bench.yml index 7260b2a46..68670a10f 100644 --- a/.github/workflows/bench.yml +++ b/.github/workflows/bench.yml @@ -75,7 +75,7 @@ jobs: run: .github/actions/scripts/save-benchmark-results.sh env: S3_BENCH_REGION: ${{ vars.S3_BENCH_REGION }} - S3_BENCH_BUCKET_NAME: ${{ vars.S3_BENCH_BUCKET_NAME }} + S3_BENCH_BUCKET_NAME: ${{ vars.S3_BENCH_RESULTS_BUCKET_NAME }} S3_BENCH_RESULTS_PREFIX: ${{ inputs.s3_bench_results_prefix }}/${{ github.job }} latency-bench: @@ -128,7 +128,7 @@ jobs: run: .github/actions/scripts/save-benchmark-results.sh env: S3_BENCH_REGION: ${{ vars.S3_BENCH_REGION }} - S3_BENCH_BUCKET_NAME: ${{ vars.S3_BENCH_BUCKET_NAME }} + S3_BENCH_BUCKET_NAME: ${{ vars.S3_BENCH_RESULTS_BUCKET_NAME }} S3_BENCH_RESULTS_PREFIX: ${{ inputs.s3_bench_results_prefix }}/${{ github.job }} cache-bench: @@ -183,5 +183,5 @@ jobs: run: .github/actions/scripts/save-benchmark-results.sh env: S3_BENCH_REGION: ${{ vars.S3_BENCH_REGION }} - S3_BENCH_BUCKET_NAME: ${{ vars.S3_BENCH_BUCKET_NAME }} + S3_BENCH_BUCKET_NAME: ${{ vars.S3_BENCH_RESULTS_BUCKET_NAME }} S3_BENCH_RESULTS_PREFIX: ${{ inputs.s3_bench_results_prefix }}/${{ github.job }} \ No newline at end of file diff --git a/.github/workflows/bench_pr.yml b/.github/workflows/bench_pr.yml index de9d47ec6..8c14d84d3 100644 --- a/.github/workflows/bench_pr.yml +++ b/.github/workflows/bench_pr.yml @@ -17,6 +17,8 @@ jobs: with: environment: PR benchmarks ref: ${{ github.event.pull_request.head.sha }} + # store results with prefix defined by PR id (github.event.number) + s3_bench_results_prefix: ${{ github.event_name == 'pull_request_target' && format('results/{0}/s3_standard', github.event.number) || null }} s3express-integration: name: Benchmarks (s3express) uses: ./.github/workflows/bench_s3express.yml @@ -24,3 +26,5 @@ jobs: with: environment: PR benchmarks ref: ${{ github.event.pull_request.head.sha }} + # store results with prefix defined by PR id (github.event.number) + s3_bench_results_prefix: ${{ github.event_name == 'pull_request_target' && format('results/{0}/s3_express', github.event.number) || null }} diff --git a/.github/workflows/bench_s3express.yml b/.github/workflows/bench_s3express.yml index ea97b61ab..a7d28408d 100644 --- a/.github/workflows/bench_s3express.yml +++ b/.github/workflows/bench_s3express.yml @@ -76,7 +76,7 @@ jobs: run: .github/actions/scripts/save-benchmark-results.sh env: S3_BENCH_REGION: ${{ vars.S3_BENCH_REGION }} - S3_BENCH_BUCKET_NAME: ${{ vars.S3_BENCH_BUCKET_NAME }} + S3_BENCH_BUCKET_NAME: ${{ vars.S3_BENCH_RESULTS_BUCKET_NAME }} S3_BENCH_RESULTS_PREFIX: ${{ inputs.s3_bench_results_prefix }}/${{ github.job }} latency-bench: @@ -129,5 +129,5 @@ jobs: run: .github/actions/scripts/save-benchmark-results.sh env: S3_BENCH_REGION: ${{ vars.S3_BENCH_REGION }} - S3_BENCH_BUCKET_NAME: ${{ vars.S3_BENCH_BUCKET_NAME }} + S3_BENCH_BUCKET_NAME: ${{ vars.S3_BENCH_RESULTS_BUCKET_NAME }} S3_BENCH_RESULTS_PREFIX: ${{ inputs.s3_bench_results_prefix }}/${{ github.job }}